Diffusion FreeBSD src repository bcddaadbef58

rman: fix overflow in rman_reserve_resource_bound()
bcddaadbef58
Actions

Description

rman: fix overflow in rman_reserve_resource_bound()

If the default range of [0, ~0] is given, then (~0 - 0) + 1 == 0. This
in turn will cause any allocation of non-zero size to fail. Zero-sized
allocations are prohibited, so add a KASSERT to this effect.

History indicates it is part of the original rman code. This bug may in
fact be older than some contributors.

Reviewed by: mhorne
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D30280

Details

Provenance

ehem_freebsd_m5p.com	Authored on Sep 27 2021, 5:13 PM
mhorne	Committed on Sep 27 2021, 5:38 PM

Reviewer

mhorne

Differential Revision

D31312: kern/rman: warn/KASSERT() on garbled reservations

Parents

rG0eb901f76007: pci_host_generic: implement bus_translate_resource (for LinuxKPI)

Branches

Unknown

Tags

Unknown

Event Timeline

mhorne committed rGbcddaadbef58: rman: fix overflow in rman_reserve_resource_bound() (authored by ehem_freebsd_m5p.com).Sep 27 2021, 5:38 PM

mhorne added an edge: D30280: kern/rman: fix overflow in rman_reserve_resource_bound().

mhorne added an edge: D31312: kern/rman: warn/KASSERT() on garbled reservations.Sep 27 2021, 5:41 PM

mhorne mentioned this in rG8e43767b3180: rman: fix overflow in rman_reserve_resource_bound().Oct 4 2021, 2:12 PM

mhorne mentioned this in rGa3acb379bdea: rman: fix overflow in rman_reserve_resource_bound().Oct 4 2021, 2:18 PM

Changes (1)

Path

Size

sys/

kern/

subr_rman.c

rGbcddaadbef58

View Options