HomeFreeBSD

ssh: ban user/hostnames with most shell metacharacters

Description

ssh: ban user/hostnames with most shell metacharacters

Cherry-picked from OpenSSH commit 7ef3787c84b6:

This makes ssh(1) refuse user or host names provided on the
commandline that contain most shell metacharacters.

Some programs that invoke ssh(1) using untrusted data do not filter
metacharacters in arguments they supply. This could create
interactions with user-specified ProxyCommand and other directives
that allow shell injection attacks to occur.

It's a mistake to invoke ssh(1) with arbitrary untrusted arguments,
but getting this stuff right can be tricky, so this should prevent
most obvious ways of creating risky situations. It however is not
and cannot be perfect: ssh(1) has no practical way of interpreting
what shell quoting rules are in use and how they interact with the
user's specified ProxyCommand.

To allow configurations that use strange user or hostnames to
continue to work, this strictness is applied only to names coming
from the commandline. Names specified using User or Hostname
directives in ssh_config(5) are not affected.

feedback/ok millert@ markus@ dtucker@ deraadt@

OpenBSD-Commit-ID: 3b487348b5964f3e77b6b4d3da4c3b439e94b2d9
(cherry picked from commit c39254c8f23379709b8e2a68dc64477d2885f1d4)

Details

Provenance
emasteAuthored on Jan 5 2024, 6:12 PM
Parents
rG221a6bc397ad: ssh: Update to OpenSSH 9.5p1
Branches
Unknown
Tags
Unknown