HomeFreeBSD

ZTS: Minimize udev_wait in zvol_misc tests

Description

ZTS: Minimize udev_wait in zvol_misc tests

The zvol_misc tests, in particular zvol_misc_volmode, make use of a
common udev_wait function to wait for zvol devices in /dev to quiesce
on Linux. On other platforms this function currently only sleeps for
one second before returning. This is insufficient, and
zvol_misc_volmode has been flaky on FreeBSD as a result.

Replace udev_wait with block_device_wait, passing through the optional
device parameter where possible. Rearrange a few checks to strengthen
the verifications we are making and avoid unnecessarily sleeping. We
must keep udev_wait in a couple places to pass in Github CI workflows.
Remove zvol_misc_volmode from the maybe failing tests on FreeBSD in
zts-report.py.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #12583

Details

Provenance
freqlabsAuthored on Oct 1 2021, 3:36 PM
GitHub <noreply@github.com>Committed on Oct 1 2021, 3:36 PM
Parents
rGce2bdcedf549: libspl: fix warning about missing spl_pagesize declaration
Branches
Unknown
Tags
Unknown