HomeFreeBSD

Avoid memory copy when verifying raidz/draid parity

Description

Avoid memory copy when verifying raidz/draid parity

Before this change for every valid parity column raidz_parity_verify()
allocated new buffer and copied there existing data, then recalculated
the parity and compared the result with the copy. This patch removes
the memory copy, simply swapping original buffer pointers with newly
allocated empty ones for parity recalculation and comparison. Original
buffers with potentially incorrect parity data are then just freed,
while new recalculated ones are used for repair.

On a pool of 12 4-wide raidz vdevs, storing 1.5TB of 16MB blocks, this
change reduces memory traffic during scrub by 17% and total unhalted
CPU time by 25%.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored-By: iXsystems, Inc.
Closes #13613

Details

Provenance
mavAuthored on Jul 5 2022, 11:27 PM
GitHub <noreply@github.com>Committed on Jul 5 2022, 11:27 PM
Parents
rG1ac7d194e5ca: Avoid memory copies during mirror scrub
Branches
Unknown
Tags
Unknown