HomeFreeBSD

FreeBSD: Fix leaked strings in libspl mnttab

Description

FreeBSD: Fix leaked strings in libspl mnttab

The FreeBSD implementations of various libspl functions for getting
mounted device information were found to leak several strings which
were being allocated in statfs2mnttab but never freed.

The Solaris getmntany(3C) and related interfaces are expected to return
strings residing in static buffers that need to be copied rather than
freed by the caller.

Use static thread-local storage to stash the mnttab structure strings
from FreeBSD's statfs info rather than strings allocated on the heap by
strdup(3).

While here, remove some stray commented out lines.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #12961

Details

Provenance
freqlabsAuthored on Jan 14 2022, 8:38 PM
GitHub <noreply@github.com>Committed on Jan 14 2022, 8:38 PM
Parents
rG12bd322dde06: man: zfs.4: miscellaneous cleanup
Branches
Unknown
Tags
Unknown