HomeFreeBSD

LinuxKPI: 802.11: fix ieee80211_schedule_txq() to avoid rtw89 panic

Description

LinuxKPI: 802.11: fix ieee80211_schedule_txq() to avoid rtw89 panic

rtw89 TX path was faulting in linuxkpi_ieee80211_next_txq() due to a
"double scheduling" check in linuxkpI_ieee80211_schedule_txq() being
incorrect:
the next pointer may be NULL there if the element is the last in the
tailq, so correctly check tqe_prev. Without the fix we may have queued
the same element to the tailq twice, and because it was the last element
and had a NULL tqe_next, that NULL value would get propogated into
another node's tqe_prev on removal, and other such nastiness.

With this rtw89 no longer panics.

Reviewed by: bz
Differential Revision: https://reviews.freebsd.org/D47006

(cherry picked from commit 41b746e05231b44c87f3a3087a7fe29966af6d0f)

Details

Provenance
ashafer_badland.ioAuthored on Oct 10 2024, 3:31 PM
bzCommitted on Oct 16 2024, 9:46 PM
Reviewer
bz
Differential Revision
D47006: rtw89: Fix TX panics
Parents
rGd36ba3989ca9: firmware: unbreak armv7
Branches
Unknown
Tags
Unknown