x86: consolidate hw watchpoint logic into new file

This is a prerequisite to using these functions outside of ddb, but also
provides some cleanup and minor refactoring. This code is almost
entirely duplicated between the two implementations, the only
significant difference being the lack of dbreg synchronization on i386.

Cleanups are:

• demote some internal functions to static
• use the constant NDBREGS instead of a '4' literal
• remove K&R definitions
• some added comments

Reviewed by: kib, jhb
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

(cherry picked from commit c02c04f113fe65001bc21363ae3ad08cf6c763eb)