HomeFreeBSD

libc: optimize memmem two-way bad character shift

Description

libc: optimize memmem two-way bad character shift

first, the condition (mem && k < p) is redundant, because mem being
nonzero implies the needle is periodic with period exactly p, in which
case any byte that appears in the needle must appear in the last p
bytes of the needle, bounding the shift (k) by p.

second, the whole point of replacing the shift k by mem (=l-p) is to
prevent shifting by less than mem when discarding the memory on shift,
in which case linear time could not be guaranteed. but as written, the
check also replaced shifts greater than mem by mem, reducing the
benefit of the shift. there is no possible benefit to this reduction of
the shift; since mem is being cleared, the full shift is valid and
more optimal. so only replace the shift by mem when it would be less
than mem.

musl commits:
8f5a820d147da36bcdbddd201b35d293699dacd8
122d67f846cb0be2c9e1c3880db9eb9545bbe38c

Obtained from: musl

(cherry picked from commit 7dbcd06e63101d51e6a777f7315cfde794411e53)

Details

Provenance
emasteAuthored on Nov 19 2020, 12:02 AM
Parents
rGe7c49bf5d78c: clang-format libc string functions imported from musl
Branches
Unknown
Tags
Unknown