HomeFreeBSD

Invoke zdb by guid to avoid import errors

Description

Invoke zdb by guid to avoid import errors

The problem that was occurring is basically that a device was removed
by ztest and replaced with another device. It was then reguided. The
import then failed because there were two possible imports with the
same name; one with the new guid, and one with the old. This can
happen because the label writes from the device removal/replacement
can be subject to ztest's error injection.

The other ways to fix this would be to change the error injection to
not trigger on removals (which may not be technically feasible), or
to change the import code to not report configurations that are so
short on devices (which would potentially have unpleasant end-user
effects when trying to recover from data losses/device configuration
issues).

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #15298

Details

Provenance
pcd_delphix.comAuthored on Sep 22 2023, 11:08 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Sep 28 2023, 9:28 PM
Parents
rG0aabd6b48228: ZIL: Avoid dbuf_read() in ztest_get_data()
Branches
Unknown
Tags
Unknown