Page MenuHomeFreeBSD

mp39590_gmail.com (Mikhail)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 28 2015, 8:38 PM (228 w, 3 d)

Recent Activity

Jan 24 2018

mp39590_gmail.com added a comment to D13944: mail/*notmuch: take maintainership, update to 0.26 & refactor.

It's OK from me to pass maintainership.

Jan 24 2018, 11:38 AM

Jan 19 2018

mp39590_gmail.com added a comment to D13944: mail/*notmuch: take maintainership, update to 0.26 & refactor.

Unconditionally install completions according to Porter's Handbook Chapter 6.31.. This adds extra build, but no run dependencies.

Option there exactly because of extra dependency (I dislike extra dependencies), one solution is to install completion manually unconditionally with port infrastructure.

Jan 19 2018, 12:17 PM

Aug 10 2017

mp39590_gmail.com added a comment to D11752: mail/notmuch: Update to version 0.25.

please, commit with the long list for test skip.

Aug 10 2017, 1:00 PM
mp39590_gmail.com accepted D11752: mail/notmuch: Update to version 0.25.
Aug 10 2017, 12:59 PM
mp39590_gmail.com added a comment to D11752: mail/notmuch: Update to version 0.25.
In D11752#247995, @jrm wrote:

Maybe my previous message was hidden that explained why? Did you click "Show older changes"?
I don't think *failed* tests should be skipped. I'm also inclined to not skip any of them and leave the broken tests in; that might be more incentive for someone to attempt to fix the broken tests.

Aug 10 2017, 12:43 PM
mp39590_gmail.com added a comment to D11752: mail/notmuch: Update to version 0.25.

Why so many tests are in skip test variable? From your log I can see that it should contain only 3 (because only 3 tests has failed): atomicity message-property database-modified

Aug 10 2017, 12:03 PM

Aug 9 2017

mp39590_gmail.com accepted D11752: mail/notmuch: Update to version 0.25.
In D11752#247760, @jrm wrote:

Can you update NOTMUCH_SKIP_TESTS variable after "make test" passage? - it should be almost empty, if not removed at all.

Could you be more specific? I'm not sure exactly what you are looking for.

Aug 9 2017, 5:59 PM
mp39590_gmail.com requested changes to D11752: mail/notmuch: Update to version 0.25.

Can you update NOTMUCH_SKIP_TESTS variable after "make test" passage? - it should be almost empty, if not removed at all.
Bash completion path should stay - prefix/share is for shareable content, as functions.

Aug 9 2017, 4:18 PM

Jul 20 2017

mp39590_gmail.com accepted D11644: mail/notmuch: Fix issues and upgrade to 0.24.2.
Jul 20 2017, 9:41 PM