User Details
- User Since
- Jun 6 2021, 5:11 PM (248 w, 6 d)
Today
I would get rid of the type changes, as I don't think they actually improve the code. The end_result change is wrong.
Yesterday
Fri, Mar 13
Looks pretty reasonable, though I'll let Steve Kargl have the last word.
Needs a man page.
Sun, Mar 8
Sat, Mar 7
Wed, Mar 4
Tue, Mar 3
No objections as far as my sole affected port (devel/objconv) is concerned.
net/aoe should probably removed entirely, as it is broken on all supported versions of FreeBSD (FreeBSD 15 breaks the same way afaik) and attempts to repair it have not been fruitful.
Sat, Feb 28
Looks right. Let's wait for someone from docs to chime in.
LGTM. Please bump PORTREVISION for this kind of change. You can add that in when you land the fix.
Fri, Feb 27
Thu, Feb 26
I didn't manage to get the change in with this cycle, but will try to do it with the next one (in a week or two probably).
Don't worry about it!
I believe that, but it seems to be a false positive.
Please check if the condition can actually occur in practice.
Could you show me an example where line 86 is reached while fp is a null pointer?
Wed, Feb 25
Tue, Feb 24
Mon, Feb 23
I've already given a LGTM a month ago, but forgot to add the review action. Please land!
Fri, Feb 20
Thu, Feb 19
What's the rationale for this removal? Shall the user not be able to print?
Wed, Feb 18
I already have an update to an older development snapshot prepared and will work off that.
There is no need to update this patch, as I do not plan to use it.
Note that it needs rework in any case, for example, we do not permit downloading of files after the fetch phase, so “allow the test target to download them on-demand” is incorrect and will fail in a Poudriere jail.
I am not going to do this as per policy.
This patch is REJECTED.