♟ fuz

In D54303#1241050, @markj wrote:

Approved. If this doesn't land soon, say in the next day or two, we should revert the original change until it does.

In D54104#1238790, @adamw wrote:

One question: should go:1.24 just mean go:1.24+? Do we foresee any reason that go:1.24 should bring in 1.24 when GO_VERSION == 1.25? Or would that lead to confusion?

You two have completely flipped me on the correct approach, and I'm now all-in on go.mk bringing in the right version for FreeBSD.org, not go.dev. I'm now wondering whether + should be more than just an optional feature. What do you two think?

libc/tests/string: improve stpncpy() "bounds" unit test

libc/amd64: fix overread conditions in stpncpy()

lib/libc: implement C23 memalignment()

*/*: remove recallocarray() compat shims following import into libc

lib/libc: add recallocarray()

net-mgmt/bind_exporter: actually remove the deprecatin notice

games/wesnoth: fix build following addition of unreachable(3)

x11-servers/xwayland: bump to 24.1.9

editors/rehex: update to 0.63.4

devel/redo: Change upstream TLD from ".eu" to ".uk".

net-mgmt/bind_exporter: remove Go toolchain version pinning

x11-servers/xwayland: bump to 24.1.9

archivers/libzip: take

devel/goreleaser: update to 2.13.0

games/wesnoth: fix build following addition of unreachable(3)

devel/redo: Change upstream TLD from ".eu" to ".uk".

www/ladybird: drop maintainership

devel/tbox: update to 1.7.9

editors/rehex: update to 0.63.4

converters/simdutf: update to 7.7.0

sys/_types.h: recognise char8_t as a builtin type in C++20

Could we yoink the logic from python.mk for this?

libc/limits_test: add no-op testcase to satisfy kyua

Revert "stddef.h: add unreachable() for C23 compliance"

Patch looks fine. Approved for commit once you feel like you have tested it sufficiently.

There seems to be a stray gcc in the file.

libc/stdc_has_single_bit.c: fix gcc warning (-Wparentheses)

Maybe both actually...

I recommend that instead of !defined(__cplusplus), maybe we do !defined(unreachable). This should also cover C codebases with their own unreachable macros and matches what we do for offsetof.

powerpc/_stdint.h: fix SIG_ATOMIC_{MIN,MAX,WIDTH}

In D53975#1233980, @haraldei wrote:

In D53975#1233152, @fuz wrote:

For testing, the gold standard is to build the port and execute the test suite on as many platforms we support as possible, on all currently supported OS versions (that is, 13.5, 14.3, and 15.0).

Do I have access to, and can I use the ref*-machines for that?

I have run the tests on amd64, natively on my dev machine, and can probably get the aarch64 emulation up and running too soon. But it would be nice to be able to at least run the tests on real hardware too.

man/man3: add cross references to stdbit(3)

libc/tests: add stdbit test framework and unit tests

libc/stdbit: add man pages for stdbit functions

man/man3: add stdbit.3

libc/tests: add test for *_MAX, *_MIN, and *_WIDTH

libc: implement C23 <stdbit.h> functions

sys/stdint.h: add C23 _WIDTH macros

sys/limits.h: add C23 _WIDTH macros

simd.7: add scalar strchrnul() for RISC-V to manpage

libc: scalar strchrnul() in RISC-V assembly

libc: scalar strnlen() in RISC-V assembly

depend-cleanup.sh: clean up after riscv64 enhanced string function patch set

simd.7: add scalar strnlen() for RISC-V to manpage

libc: scalar memcpy() in RISC-V assembly

simd.7: document bcopy() and bzero() as accelerated on riscv64

simd.7: add scalar memcpy() for RISC-V to manpage

libc: scalar strlen() in RISC-V assembly

libc/riscv64: implement bcopy() and bzero() through memcpy() and memset()

simd.7: add scalar strlen() for RISC-V to manpage

simd.7: add scalar memset() for RISC-V to manpage

libc: scalar memset() in RISC-V assembly

libc: scalar memchr() in RISC-V assembly

simd.7: add scalar memchr() for RISC-V to manpage

libc: scalar strrchr() in RISC-V assembly

simd.7: add scalar strrchr() for RISC-V to manpage

unreachable.3: add missing brace in example

stddef.h: add unreachable() for C23 compliance

jemalloc: avoid clash with C23 unreachable() macro

time.h: add timegm() to the C23 namespace

uchar.h: add char8_t

In D53831#1229909, @fuz wrote:

The point of this test is to check that I got the definitions right, as we do them manually. We could actually use compiler builtins for the various sys/$ARCH/include files to directly grab the types from the C compiler, but we don't.

But didn't you propose making exactly that change?

For testing, the gold standard is to build the port and execute the test suite on as many platforms we support as possible, on all currently supported OS versions (that is, 13.5, 14.3, and 15.0). If you don't have access to some architectures, you can skip testing there, but especially for an infrastructure port like this it is a good idea to be thorough.

fuz (Robert Clausecker)
User

Projects

User Details

Recent Activity
View All

Today

Yesterday

Sun, Dec 14

Fri, Dec 12

Wed, Dec 10

Tue, Dec 9

Mon, Dec 8

Sat, Dec 6

Fri, Dec 5

Thu, Dec 4

Wed, Dec 3

Tue, Dec 2

Mon, Dec 1

Sun, Nov 30

Fri, Nov 28

Thu, Nov 27

fuz (Robert Clausecker)User