look good to me

OK. I'll keep my patch waiting for better times, then.
BTW, thanks for the review

My original idea was to add it a slave port, but then I've seen the work on FLAVORS and I preferred to wait FLAVORS be ready and use it.

• Rename any reference/depends of php-xdebug to pecl-xdebug

In D11863#275171, @bhughes wrote:

In D11863#246745, @sunpoet wrote:

To me, the node.mk is incomplete. At least a port maintainer is not able to mark the port requiring node 6.x and above (e.g. USES=node:6+ or USES=node:6-).

I agree. Unfortunately my Makefile-fu isn't strong enough at the moment to make that possible. If anyone knows how or can point me at examples of how to do it, I would be very appreciative.

python.mk can be a good reference for that. I'm willing to help, if you need and I'm able to

This PR can be merged in quarterly.

Commit message:

I decide to adopt node8 as default, to be consistent with www/npm.
Moreover, I guess a portrevision bump is needed because of the dependency's name change.

• Add the missing entry in the category's Makefile

• Remove portrevision bump, not needed

Build error is only on FreeBSD CURRENT, I guess because of llvm 5.x Probably it was a warning on previous clang version.
The current port is already working on 10.x and 11.x, but I'm not sure that the patch fix only the C++ syntax or changes the binary as well. The new patch is now applied on every FreeBSD version.
A better solution, avoiding portrevision bump, could be to change the patch as extrapatch and apply it only if freebsd version >= 1200000.
I'll ask the maintainer.