Differential D4069

iwn(4): fix mbuf leaks in error paths
ClosedPublic
Actions

Authored by avos on Nov 2 2015, 4:51 PM.

Details

Reviewers

adrian

Commits

rS290427: iwn(4): various simple fixes

Summary

Fix mbuf leaks in iwn_raw_xmit() and iwn_xmit_task() (regression since rS288178).
Check IWN_FLAG_RUNNING flag under lock.
Remove m->m_pkthdr.rcvif initialization (fixed in rS283994 ?).
Enclose some values in return statements into parentheses.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 9888.Nov 2 2015, 4:51 PM

avos retitled this revision from to iwn(4): fix mbuf leaks in error paths.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptNov 2 2015, 4:51 PM

I'm reviewing/testing this one now.

Looks fine! Did you test it on anything?

This revision is now accepted and ready to land.Nov 5 2015, 1:59 AM

In D4069#85524, @adrian wrote:

Looks fine! Did you test it on anything?

m->m_pkthdr.rcvif = (void *) ni;

is already set on other devices/drivers.

Other changes look trivial (but not tested).

Looks fine: i'm running it. Commit away!

Closed by commit rS290427: iwn(4): various simple fixes (authored by avos). · Explain WhyNov 5 2015, 10:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iwn/

if_iwn.c

14 lines

Diff 9888

View Options

iwn(4): fix mbuf leaks in error pathsClosedPublicActions