Page MenuHomeFreeBSD

[new port] www/py-graphite-api: Graphite-web, without the interface. Just the rendering HTTP API
Needs ReviewPublic

Authored by ultima1252_gmail.com on Nov 2 2015, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 12:43 AM
Unknown Object (File)
Thu, Mar 7, 12:43 AM
Unknown Object (File)
Thu, Mar 7, 12:05 AM
Unknown Object (File)
Wed, Mar 6, 11:20 PM
Unknown Object (File)
Dec 20 2023, 1:12 AM
Unknown Object (File)
Nov 13 2023, 12:13 PM
Unknown Object (File)
Nov 13 2023, 8:40 AM
Unknown Object (File)
Nov 9 2023, 12:08 AM
Subscribers
This revision needs review, but all reviewers have resigned.

Details

Reviewers
koobs
Test Plan

Poudriere: Build on 102amd64, 102i386, 93amd64, 93i386. All build successfully. Only tested on python 2.7, will test 3.x at a later date.

Portlint:

www/py-graphite-api: 
WARN: Makefile: no port directory /usr/ports/graphics/py-cairocffi found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: no port directory /usr/ports/devel/py-structlog found, even though it is listed in RUN_DEPENDS.
0 fatal errors and 2 warnings found.
graphics/py-cairocffi:
WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "DEPENDS".
0 fatal errors and 1 warning found.
x11/py-xcffib:
WARN: Makefile: no port directory /usr/ports/devel/py-cffi  py27-six>0 found, even though it is listed in BUILD_DEPENDS.
WARN: Makefile: no port directory /usr/ports/devel/py-cffi  py27-six>0 found, even though it is listed in RUN_DEPENDS.
WARN: Makefile: extra item placed in the *_DEPENDS section, for example, "DEPENDS".
0 fatal errors and 3 warnings found.
devel/py-structlog: looks fine.
databases/py-cyanite: looks fine.

Can't seem to get rid of the *_DEPENDS error. Moving DEPENDS just adds a different warning so ignoring it. Not working in /usr/ports so that warning is being ignored.

As far as testing the end pkg, Waiting on requester feedback.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1005
Build 1008: arc lint + arc unit

Event Timeline

ultima1252_gmail.com retitled this revision from to www/py-graphite-api: Graphite-web, without the interface. Just the rendering HTTP API.
ultima1252_gmail.com updated this object.
ultima1252_gmail.com edited the test plan for this revision. (Show Details)
ultima1252_gmail.com added a reviewer: koobs.
  • For any [NEW PORT]'s, add the change to <category>/Makefile
  • Since I can't see any testing in the Test Plan section: Before using USES=python, confirm it works with 3.x, or set USES=python:-2.7
  • It appears there are some portlint(8) violations here. Please confirm in Test Plan section that these pass QA
databases/py-cyanite/Makefile
13

LICENSE_FILE exists in WRKSRC? If so, add it here.

15

*Very* unlikely a BUILD_DEPENDS, but rather RUN_DEPENDS, check.

17

Since I can't see any testing in the Test Plan section:

Are you sure it builds on Python 3.x? Otherwise USES=python:-2.7

databases/py-cyanite/pkg-descr
3

Is this the URL in setup.py:homepage= ? If not, use that (+ https:// if its available)

devel/py-sentry/Makefile
11

Remove "Sentry is a" as a prefix in COMMENT. Portlint should have told you something about it.

devel/py-structlog/Makefile
11

Again, remove PORTNAME from COMMENT prefix

Use the setup.py:description= description, tailored to meet portlint(8) rules.

graphics/py-cairocffi/Makefile
17

This doesn't work, and := is no longer used/recommended/allowed. Read Porters HandBook: Section 5.8. Dependencies

26

Sure its a BUILD_DEPENDS and not RUN_DEPENDS?

www/py-graphite-api/Makefile
11

Is there a -web port? Does this conflict with it?

Can both be installed to get cumulative functionality?

16–23

These don't all look like BUILD_DEPENDS. Please re-check.

31–34

Capitalize beginning of each *_DESC and check Mk/bsd.options.desc.mk to make sure they don't already exist there.

x11/py-xcffib/Makefile
19

Can't do this anymore, see Porters Handbook: Dependencies

koobs requested changes to this revision.Nov 2 2015, 4:28 AM
koobs edited edge metadata.
This revision now requires changes to proceed.Nov 2 2015, 4:28 AM
koobs added a subscriber: Python.
ultima1252_gmail.com added inline comments.
databases/py-cyanite/Makefile
13

no license on this one

databases/py-cyanite/pkg-descr
3

Thats the one in setup.py =]

devel/py-sentry/Makefile
11

Portlint -AC doesn't mention it but fixed! (I wonder if its because the S is cap'd)

ultima1252_gmail.com edited edge metadata.

Several fixes from feedback

linimon retitled this revision from www/py-graphite-api: Graphite-web, without the interface. Just the rendering HTTP API to [new port] www/py-graphite-api: Graphite-web, without the interface. Just the rendering HTTP API.Feb 7 2019, 7:53 PM
This revision now requires changes to proceed.Feb 7 2019, 7:53 PM
This revision now requires review to proceed.Jun 1 2019, 1:05 PM