Page MenuHomeFreeBSD
Differential D32016

vmci: fix panic due to freeing unallocated resources
ClosedPublic
Actions

Authored by mp on Sep 18 2021, 8:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 3, 1:54 PM
Unknown Object (File)
Sun, Aug 2, 6:10 AM
Unknown Object (File)
Sun, Aug 2, 5:20 AM
Unknown Object (File)
Sat, Aug 1, 6:04 AM
Unknown Object (File)
Thu, Jul 30, 1:01 AM
Unknown Object (File)
Mon, Jul 27, 2:26 PM
Unknown Object (File)
Tue, Jul 21, 1:08 AM
Unknown Object (File)
Sat, Jul 18, 2:38 PM
View All Files
Subscribers
imp

Details

Reviewers
marcus
arrowd
Commits
rGb5d236785dc3: vmci: fix panic due to freeing unallocated resources
rG4e5c1be4202a: vmci: fix panic due to freeing unallocated resources
rG0f14bcbe3840: vmci: fix panic due to freeing unallocated resources
Summary

An error mapping PCI resources results in a panic due to unallocated
resources being freed up. This change puts the appropriate checks in
place to prevent the panic.

PR: 252445
Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>
Tested by: marcus
MFC after: 1 week
Sponsored by: VMware

Test Plan

Along with user testing, also simulated error by inserting a ENXIO
return in vmci_map_bars().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41595
Build 38484: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
vmware/
vmci/
9 lines
3 lines
2 lines
48 lines
3 lines

Diff 95345

View Options

sys/dev/vmware/vmci/vmci.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_event.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_kernel_if.h

Loading...
View Options

sys/dev/vmware/vmci/vmci_kernel_if.c

Loading...
View Options

sys/dev/vmware/vmci/vmci_queue_pair.c

Loading...