genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations
ClosedPublic
Actions

Authored by imp on Sep 6 2021, 4:24 PM.

Details

Reviewers

Commits

rGa17cf1bed9d0: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations
rG5d8f8ab1eb40: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations
rGecfbb2e30241: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations

Summary

Linux fails to build now because the mkdtemp in the bootstrapped
environment wants 6 or more X's. Use 10 out of an abundance of caution.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 6 2021, 4:24 PM

imp created this revision.

Harbormaster completed remote builds in B41408: Diff 94740.Sep 6 2021, 4:24 PM

imp added a reviewer: arichardson.Sep 6 2021, 4:25 PM

LGTM. Possibly we should bootstrap the mkdtemp(3) sources rather than the host (glibc) ones to ensure all bootstrapped binaries behave the same way as they do on FreeBSD.

This revision is now accepted and ready to land.Sep 6 2021, 7:52 PM

Closed by commit rGecfbb2e30241: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations (authored by imp). · Explain WhySep 7 2021, 4:13 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGecfbb2e30241: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations.

imp added a commit: rG5d8f8ab1eb40: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations.Sep 22 2021, 2:31 PM

imp added a commit: rGa17cf1bed9d0: genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementations.Oct 2 2021, 4:44 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

genoffset.sh

2 lines

Diff 94845

View Options

genoffset.sh: Use 10 X's instead of 5 for pick mkdtemp implementationsClosedPublicActions