Page MenuHomeFreeBSD

do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
ClosedPublic

Authored by sjg on Oct 15 2015, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 3, 4:41 AM
Unknown Object (File)
Sun, Jul 27, 8:30 PM
Unknown Object (File)
Jul 7 2025, 6:30 AM
Unknown Object (File)
Jul 7 2025, 5:56 AM
Unknown Object (File)
Jul 6 2025, 11:06 AM
Unknown Object (File)
Jul 2 2025, 4:54 PM
Unknown Object (File)
Jul 1 2025, 2:59 AM
Unknown Object (File)
Jun 30 2025, 10:59 AM
Subscribers
None

Details

Reviewers
marcel
Summary

FALLTHROUGH results in return of EINVAL since ifmedia_ioctl()
does not grok SIOC{ADD,DEL}MULTI

This hurts if caller is paying attention to errors.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 769
Build 769: arc lint + arc unit

Event Timeline

sjg retitled this revision from to do not FALLTHROUGH for SIOC{ADD,DEL}MULTI.
sjg updated this object.
sjg edited the test plan for this revision. (Show Details)
marcel edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 30 2015, 4:20 PM