linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls.
ClosedPublic
Actions

Authored by dchagin on Aug 16 2021, 8:06 AM.

Details

Reviewers

None

Group Reviewers

Commits

rG71d5b525f5d2: linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls.
rG099fa2feb36f: linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls.

Summary

Avoid calculating d_off value as it is specific to the underlying filesystem
and can be used by others API, like lseek(), seekdir() as input offset.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41056
Build 37945: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 16 2021, 8:06 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 16 2021, 8:06 AM

dchagin requested review of this revision.Aug 16 2021, 8:06 AM

Harbormaster completed remote builds in B41054: Diff 93735.Aug 16 2021, 8:06 AM

dchagin added a reviewer: Linux Emulation.Aug 16 2021, 8:06 AM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

blank line restore

Harbormaster completed remote builds in B41056: Diff 93741.Aug 16 2021, 11:52 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 31 2022, 5:51 PM

Closed by commit rG099fa2feb36f: linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls. (authored by dchagin). · Explain Why

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG099fa2feb36f: linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls..

dchagin added a commit: rG71d5b525f5d2: linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls..Jun 17 2022, 7:42 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_file.c

6 lines

Diff 93741

View Options

sys/compat/linux/linux_file.c

linux(4): Fixup miscalculation of d_off of struct dirent in getdents() syscalls.ClosedPublicActions