Differential D3695
devel/tcltls: Make libtls.h header tcl private Authored by brnrd on Sep 18 2015, 8:09 PM. Tags None Referenced Files
Subscribers
Details Proposed commit message: devel/tcltls: Make libtls.h header tcl private - Move libtls.h header to include/tlsX.Y dir - Fix conflict with security/libressl - Whilst here: Fix NO_SSL2/3 detection PR: 202676 Differential_Revision: D???? Reviewed_by: vsevolod (mentor), koobs (mentor) Approved by: vsevolod (mentor), koobs (mentor)
Diff Detail
Event TimelineComment Actions I don't like files not belonging to lang/tclXY being installed in directories owned by lang/tclXY. I suggest to either rename the file to tcltls.h or install it in include/${TCLPKG}. Comment Actions After looking into it, it is my opinion that the tls.h file is not meant to be used outside of the compilation phase of tcltls itself. I suggest to remove it altogether from the installation set. Here's my suggestion. Index: devel/tcltls/Makefile =================================================================== --- devel/tcltls/Makefile (revision 397373) +++ devel/tcltls/Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= tcltls PORTVERSION= 1.6.7 +PORTREVISION= 1 CATEGORIES= devel tcl MASTER_SITES= SF/tls/tls/${PORTVERSION} DISTNAME= tls${PORTVERSION}-src @@ -26,13 +27,14 @@ TCLPKG= tls${PORTVERSION} WRKSRC= ${WRKDIR}/${TCLPKG} -PLIST_FILES= include/tls.h \ - lib/${TCLPKG}/libtls.so.1 \ +PLIST_FILES= lib/${TCLPKG}/libtls.so.1 \ lib/${TCLPKG}/pkgIndex.tcl \ lib/${TCLPKG}/tls.tcl PORTDOCS= * post-patch: + # Do not install tls.h + ${REINPLACE_CMD} -e '/^PKG_HEADERS/s|^|#|' ${WRKSRC}/Makefile.in ${REINPLACE_CMD} -e \ 's,package require tls.*,load ${WRKSRC}/libtls.so.1;\ source ${WRKSRC}/tls.tcl,' \ Comment Actions Update patch as per Pietro's suggestion This has maintainer approval as per https://bugs.freebsd.org/202676 |