Paths

Table of Contentst

Fix check to enable perl5 tests
ClosedPublic
Actions

Authored by AMDmi3 on Oct 6 2015, 7:54 PM.

Details

Reviewers

sunpoet
mat

Group Reviewers

portmgr

Commits

rG2c1cbd083696: bhyve: maintain a list of acpi devices
rGfbd045021d9f: bhyve: maintain a list of acpi devices
rP398768: Do not provide empty do-test target for perl5-using ports

Summary

Instead of NO_PERL5_TEST which duplicates NO_TEST, a check should be added to perl5.mk to only enables perl5 tests if perl5 build is used

Test Plan

Tested on ftp/curl

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

AMDmi3 updated this revision to Diff 9197.Oct 6 2015, 7:54 PM

AMDmi3 retitled this revision from to Fix check to enable perl5 tests.

AMDmi3 updated this object.

AMDmi3 edited the test plan for this revision. (Show Details)

AMDmi3 added a reviewer: sunpoet.

Herald added a reviewer: portmgr. · View Herald TranscriptOct 6 2015, 7:54 PM

Macro shipit:

This revision is now accepted and ready to land.Oct 6 2015, 8:08 PM

Actually, it may maybe be better to add a USE_PERL5=test thing, that would be added by the configure/modbuild* cases, would it not ?

In D3830#79014, @mat wrote:

Actually, it may maybe be better to add a USE_PERL5=test thing, that would be added by the configure/modbuild* cases, would it not ?

What purpose will it serve? E.g. it has no meaning without configure/modbuild*.

Now I understand what you mean in previous mail. :)
Please commit.
Thanks!

Closed by commit rP398768: Do not provide empty do-test target for perl5-using ports (authored by AMDmi3). · Explain WhyOct 7 2015, 4:19 PM

This revision was automatically updated to reflect the committed changes.

AMDmi3 mentioned this in rP398768: Do not provide empty do-test target for perl5-using ports.

corvink added a commit: rGfbd045021d9f: bhyve: maintain a list of acpi devices.Feb 14 2023, 7:29 AM

corvink added a commit: rG2c1cbd083696: bhyve: maintain a list of acpi devices.Feb 28 2023, 10:14 AM

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

Uses/

perl5.mk

2 lines

O5: Ports Framework

ftp/

curl/

Makefile

1 line

Diff 9217

View Options

head/Mk/Uses/perl5.mk