Page MenuHomeFreeBSD

Fix check to enable perl5 tests
ClosedPublic

Authored by AMDmi3 on Oct 6 2015, 7:54 PM.

Details

Summary

Instead of NO_PERL5_TEST which duplicates NO_TEST, a check should be added to perl5.mk to only enables perl5 tests if perl5 build is used

Test Plan

Tested on ftp/curl

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

AMDmi3 retitled this revision from to Fix check to enable perl5 tests.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)
AMDmi3 added a reviewer: sunpoet.
mat added a reviewer: mat.
mat added a subscriber: mat.

Macro shipit:

This revision is now accepted and ready to land.Oct 6 2015, 8:08 PM

Actually, it may maybe be better to add a USE_PERL5=test thing, that would be added by the configure/modbuild* cases, would it not ?

In D3830#79014, @mat wrote:

Actually, it may maybe be better to add a USE_PERL5=test thing, that would be added by the configure/modbuild* cases, would it not ?

What purpose will it serve? E.g. it has no meaning without configure/modbuild*.

sunpoet edited edge metadata.

Now I understand what you mean in previous mail. :)
Please commit.
Thanks!