Differential D31054

cam(4): preserve alloc_flags when copying CCBs
ClosedPublic
Actions

Authored by trasz on Jul 5 2021, 1:58 PM.

Details

Reviewers

imp

Group Reviewers

cam

Commits

rG13aa56fcd596: cam(4): preserve alloc_flags when copying CCBs

Summary

Before UMA CCBs, all CCBs were of the same size, and could
be trivially copied using bcopy(9). Now we have to preserve
alloc_flags, otherwise we might end up attempting to free
stack-allocated CCB to UMA; we also need to take CCB size
into account.

This fixes kernel panic which would occur when trying to access
a stopped (as in, SCSI START STOP, also "ctladm stop") SCSI device.

Reported By: Gary Jennejohn <gljennjohn@gmail.com>
Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40309
Build 37198: arc lint + arc unit

Event Timeline

trasz created this revision.Jul 5 2021, 1:58 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 5 2021, 1:58 PM

Herald added a subscriber: imp. · View Herald Transcript

trasz requested review of this revision.Jul 5 2021, 1:58 PM

Harbormaster completed remote builds in B40309: Diff 91801.Jul 5 2021, 1:58 PM

trasz added a reviewer: imp.Jul 5 2021, 2:01 PM

trasz added a subscriber: NetApp.

imp accepted this revision.Jul 6 2021, 1:57 AM

This revision is now accepted and ready to land.Jul 6 2021, 1:57 AM

(Tinderboxed.)

Closed by commit rG13aa56fcd596: cam(4): preserve alloc_flags when copying CCBs (authored by trasz). · Explain WhyJul 6 2021, 8:55 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG13aa56fcd596: cam(4): preserve alloc_flags when copying CCBs.

Revision Contents
Changeset List

Path

Size

sys/

cam/

cam_periph.c

25 lines

Diff 91801

View Options

cam(4): preserve alloc_flags when copying CCBsClosedPublicActions