Clang: stop linking _p libs for -pg as of FreeBSD 14
ClosedPublic
Actions

Authored by emaste on Jun 21 2021, 9:51 PM.

Details

Reviewers

Commits

rGd004f3428f95: clang: stop linking _p libs for -pg as of FreeBSD 14
rG2e96f2635591: clang: stop linking _p libs for -pg as of FreeBSD 14
rGb762974cf4b9: clang: stop linking _p libs for -pg as of FreeBSD 14

Summary

In D30833 I propose disabling the PROFILE option by default, so follow suit in Clang and avoid linking against _p libs.

Posted for review in the FreeBSD context; I will upstream (with test changes) based on discussion here.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 21 2021, 9:51 PM

emaste created this revision.

emaste mentioned this in D30833: Enable WITHOUT_PROFILE by default.

Restore missing {

Fix getTriple() in freebsd::Linker::ConstructJob()

Upstream review at https://reviews.llvm.org/D104753

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2021, 5:13 PM

Closed by commit rGb762974cf4b9: clang: stop linking _p libs for -pg as of FreeBSD 14 (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGb762974cf4b9: clang: stop linking _p libs for -pg as of FreeBSD 14.

emaste added a commit: rG2e96f2635591: clang: stop linking _p libs for -pg as of FreeBSD 14.Jul 11 2021, 11:29 PM

emaste added a commit: rGd004f3428f95: clang: stop linking _p libs for -pg as of FreeBSD 14.

Revision Contents
Changeset List

Path

Size

contrib/

llvm-project/

clang/

lib/

Driver/

ToolChains/

FreeBSD.cpp

17 lines

Diff 91205

View Options

contrib/llvm-project/clang/lib/Driver/ToolChains/FreeBSD.cpp

Clang: stop linking _p libs for -pg as of FreeBSD 14ClosedPublicActions