Page MenuHomeFreeBSD
Differential D3659

net80211: drop ieee80211_beacon_offsets parameter from ieee80211_beacon_alloc() and ieee80211_beacon_update()
ClosedPublic
Actions

Authored by avos on Sep 13 2015, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 9:06 AM
Unknown Object (File)
Tue, Mar 25, 4:22 PM
Unknown Object (File)
Mar 7 2025, 11:17 PM
Unknown Object (File)
Feb 20 2025, 1:51 AM
Unknown Object (File)
Feb 18 2025, 6:22 PM
Unknown Object (File)
Feb 17 2025, 2:28 AM
Unknown Object (File)
Feb 16 2025, 2:43 AM
Unknown Object (File)
Jan 12 2025, 10:43 AM
View All 100 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS288636: net80211: drop ieee80211_beacon_offsets parameter from ieee80211_beacon_alloc…

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 8729.Sep 13 2015, 5:20 PM
avos retitled this revision from to net80211: drop ieee80211_beacon_offsets parameter from ieee80211_beacon_alloc() and ieee80211_beacon_update().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2015, 5:20 PM
avos added a parent revision: D3658: net80211: include one copy of struct ieee80211_beacon_offsets into ieee80211vap.Sep 13 2015, 5:20 PM
avos updated this revision to Diff 8758.Sep 14 2015, 8:09 PM

Add wtap to the diff.

adrian edited edge metadata.Oct 3 2015, 6:37 AM

This doesn't apply to head; if_rum is missing the call to ieee80211_beacon_update().

Closed by commit rS288636: net80211: drop ieee80211_beacon_offsets parameter from ieee80211_beacon_alloc… (authored by adrian). · Explain WhyOct 3 2015, 10:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ath/
6 lines
mwl/
3 lines
ral/
5 lines
4 lines
3 lines
usb/
wlan/
6 lines
7 lines
2 lines
wpi/
7 lines
wtap/
4 lines
net80211/
14 lines
5 lines

Diff 9109

View Options

head/sys/dev/ath/if_ath_beacon.c

# Created by: Gerhard Häring <gh@ghaering.de> # Created by: Gerhard Häring <gh@ghaering.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= rdiff-backup PORTNAME= rdiff-backup
PORTVERSION= 1.2.8 DISTVERSION= 2.0.0
PORTREVISION= 3
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= sysutils CATEGORIES= sysutils python
koobsUnsubmitted
Done
Inline Actions

Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in PyPI)

koobs: Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in…
MASTER_SITES= SAVANNAH \ MASTER_SITES= CHEESESHOP
LOCAL/vd/${PORTNAME}${PKGNAMESUFFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= uzsolt@uzsolt.hu MAINTAINER= uzsolt@uzsolt.hu
COMMENT= Local/remote mirroring+incremental backup COMMENT= Easy to use and efficient backup and restore utility
koobsUnsubmitted
Not Done
Inline Actions

Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible:

in rdiff-backups case: Backup and Restore utility, easy to use, efficient, locally and remotely usable

koobs: Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible: in…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the comments as follows. This is a bit different from what is is the description to not exceed 70 characters limit.

COMMENT=	Easy to use and efficient backup and restore utility
tagattie: Will change the comments as follows. This is a bit different from what is is the description to…
LICENSE= GPLv2 LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
koobsUnsubmitted
Not Done
Inline Actions
  • License stipulated upstream is license="GPLv2+",
  • Add LICENSE_FILE where one is provided with the distribution files. Using github, the file is COPYING. It's also contained in the CHEESESHOP (PyPI) sdist as the same filename
koobs: * License stipulated upstream is license="GPLv2+", * Add LICENSE_FILE where one is provided…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the license block as follows:

LICENSE=	GPLv2+
LICENSE_FILE=	${WRKSRC}/COPYING
tagattie: Will change the license block as follows: ``` LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING…
DEPRECATED= Uses deprecated version of python BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
EXPIRATION_DATE= 2020-09-15
LIB_DEPENDS= librsync.so:net/librsync LIB_DEPENDS= librsync.so:net/librsync
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR}
koobsUnsubmitted
Not Done
Inline Actions

These don't appear to be declared dependencies. Where did they come from?

The only setup_requires I see listed for 2.0.0 is setuptools_scm [1]

[1] setup.py: setup_requires=['setuptools_scm'],

koobs: These don't appear to be declared dependencies. Where did they come from? The only…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those two dependencies and add setuptools_scm to BUILD_DEPENDS.

BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
tagattie: Will delete those two dependencies and add `setuptools_scm` to `BUILD_DEPENDS`. ```…
USES= localbase:ldflags python:3.5+
USE_LDCONFIG= yes
koobsUnsubmitted
Not Done
Inline Actions

Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

koobs: Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to [1] https…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will switch from GITHUB to CHEESESHOP.
Delete:

USE_GITHUB=	yes

Add:

MASTER_SITES=	CHEESESHOP
tagattie: Will switch from GITHUB to CHEESESHOP. Delete: ``` USE_GITHUB= yes ``` Add: ```…
USE_PYTHON= autoplist concurrent distutils
koobsUnsubmitted
Not Done
Inline Actions

Use autoplist unless there's a compelling case note to.

Note also: autoplist can be complemented by a pkg-plist for manual entries

This package appears to install files into common (not python version specific) locations (like /usr/local/bin/) and as such must be made concurrent safe:

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

koobs: Use autoplist unless there's a compelling case note to. Note also: autoplist can be…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change USE_PYTHON as follows:

USE_PYTHON=	autoplist concurrent distutils
tagattie: Will change `USE_PYTHON` as follows: ``` USE_PYTHON= autoplist concurrent distutils ```
CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0* CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0*
koobsUnsubmitted
Not Done
Inline Actions

The other ports mentioned here probably need to be leveled up in the same manner this one does

koobs: The other ports mentioned here probably need to be leveled up in the same manner this one does
tagattieAuthorUnsubmitted
Done
Inline Actions

There is no port named rdiff-backup-devel and this line seems some leftover from the past.

So I guess this line can be removed.

tagattie: There is no port named `rdiff-backup-devel` and this line seems some leftover from the past.
koobsUnsubmitted
Not Done
Inline Actions

This can be removed yeh?

koobs: This can be removed yeh?
tagattieAuthorUnsubmitted
Done
Inline Actions

It seems I was wrong. Those ports may be installed on a machine and may conflict with the current version.
So I would leave the line as it is.

tagattie: It seems I was wrong. Those ports may be installed on a machine and may conflict with the…
PORTSCOUT= limitw:1,even PORTSCOUT= limitw:1,even
USES= python:2.7
USE_PYTHON= distutils
USE_LDCONFIG= yes
MAN1S= rdiff-backup.1 rdiff-backup-statistics.1
DOCS= CHANGELOG README COPYING FAQ.html
OPTIONS_DEFINE= DOCS
post-install: post-install:
koobsUnsubmitted
Not Done
Inline Actions

Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add them to pkg-plist

koobs: Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those 2 lines and let USE_PYTHON=autoplist handle those files.

tagattie: Will delete those 2 lines and let `USE_PYTHON=autoplist` handle those files.
${INSTALL_MAN} ${MAN1S:S,^,${WRKSRC}/,} ${STAGEDIR}${PREFIX}/man/man1 ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/_librsync.so
@${MKDIR} ${STAGEDIR}${DOCSDIR} ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/C.so
${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.for lib in C.so _librsync.so do-test:
${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME:S,-,_,}/${lib} cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m tox
.endfor
koobsUnsubmitted
Done
Inline Actions

Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here

koobs: Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/dev/mwl/if_mwl.c

# Created by: Gerhard Häring <gh@ghaering.de> # Created by: Gerhard Häring <gh@ghaering.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= rdiff-backup PORTNAME= rdiff-backup
PORTVERSION= 1.2.8 DISTVERSION= 2.0.0
PORTREVISION= 3
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= sysutils CATEGORIES= sysutils python
koobsUnsubmitted
Done
Inline Actions

Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in PyPI)

koobs: Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in…
MASTER_SITES= SAVANNAH \ MASTER_SITES= CHEESESHOP
LOCAL/vd/${PORTNAME}${PKGNAMESUFFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= uzsolt@uzsolt.hu MAINTAINER= uzsolt@uzsolt.hu
COMMENT= Local/remote mirroring+incremental backup COMMENT= Easy to use and efficient backup and restore utility
koobsUnsubmitted
Not Done
Inline Actions

Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible:

in rdiff-backups case: Backup and Restore utility, easy to use, efficient, locally and remotely usable

koobs: Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible: in…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the comments as follows. This is a bit different from what is is the description to not exceed 70 characters limit.

COMMENT=	Easy to use and efficient backup and restore utility
tagattie: Will change the comments as follows. This is a bit different from what is is the description to…
LICENSE= GPLv2 LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
koobsUnsubmitted
Not Done
Inline Actions
  • License stipulated upstream is license="GPLv2+",
  • Add LICENSE_FILE where one is provided with the distribution files. Using github, the file is COPYING. It's also contained in the CHEESESHOP (PyPI) sdist as the same filename
koobs: * License stipulated upstream is license="GPLv2+", * Add LICENSE_FILE where one is provided…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the license block as follows:

LICENSE=	GPLv2+
LICENSE_FILE=	${WRKSRC}/COPYING
tagattie: Will change the license block as follows: ``` LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING…
DEPRECATED= Uses deprecated version of python BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
EXPIRATION_DATE= 2020-09-15
LIB_DEPENDS= librsync.so:net/librsync LIB_DEPENDS= librsync.so:net/librsync
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR}
koobsUnsubmitted
Not Done
Inline Actions

These don't appear to be declared dependencies. Where did they come from?

The only setup_requires I see listed for 2.0.0 is setuptools_scm [1]

[1] setup.py: setup_requires=['setuptools_scm'],

koobs: These don't appear to be declared dependencies. Where did they come from? The only…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those two dependencies and add setuptools_scm to BUILD_DEPENDS.

BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
tagattie: Will delete those two dependencies and add `setuptools_scm` to `BUILD_DEPENDS`. ```…
USES= localbase:ldflags python:3.5+
USE_LDCONFIG= yes
koobsUnsubmitted
Not Done
Inline Actions

Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

koobs: Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to [1] https…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will switch from GITHUB to CHEESESHOP.
Delete:

USE_GITHUB=	yes

Add:

MASTER_SITES=	CHEESESHOP
tagattie: Will switch from GITHUB to CHEESESHOP. Delete: ``` USE_GITHUB= yes ``` Add: ```…
USE_PYTHON= autoplist concurrent distutils
koobsUnsubmitted
Not Done
Inline Actions

Use autoplist unless there's a compelling case note to.

Note also: autoplist can be complemented by a pkg-plist for manual entries

This package appears to install files into common (not python version specific) locations (like /usr/local/bin/) and as such must be made concurrent safe:

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

koobs: Use autoplist unless there's a compelling case note to. Note also: autoplist can be…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change USE_PYTHON as follows:

USE_PYTHON=	autoplist concurrent distutils
tagattie: Will change `USE_PYTHON` as follows: ``` USE_PYTHON= autoplist concurrent distutils ```
CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0* CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0*
koobsUnsubmitted
Not Done
Inline Actions

The other ports mentioned here probably need to be leveled up in the same manner this one does

koobs: The other ports mentioned here probably need to be leveled up in the same manner this one does
tagattieAuthorUnsubmitted
Done
Inline Actions

There is no port named rdiff-backup-devel and this line seems some leftover from the past.

So I guess this line can be removed.

tagattie: There is no port named `rdiff-backup-devel` and this line seems some leftover from the past.
koobsUnsubmitted
Not Done
Inline Actions

This can be removed yeh?

koobs: This can be removed yeh?
tagattieAuthorUnsubmitted
Done
Inline Actions

It seems I was wrong. Those ports may be installed on a machine and may conflict with the current version.
So I would leave the line as it is.

tagattie: It seems I was wrong. Those ports may be installed on a machine and may conflict with the…
PORTSCOUT= limitw:1,even PORTSCOUT= limitw:1,even
USES= python:2.7
USE_PYTHON= distutils
USE_LDCONFIG= yes
MAN1S= rdiff-backup.1 rdiff-backup-statistics.1
DOCS= CHANGELOG README COPYING FAQ.html
OPTIONS_DEFINE= DOCS
post-install: post-install:
koobsUnsubmitted
Not Done
Inline Actions

Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add them to pkg-plist

koobs: Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those 2 lines and let USE_PYTHON=autoplist handle those files.

tagattie: Will delete those 2 lines and let `USE_PYTHON=autoplist` handle those files.
${INSTALL_MAN} ${MAN1S:S,^,${WRKSRC}/,} ${STAGEDIR}${PREFIX}/man/man1 ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/_librsync.so
@${MKDIR} ${STAGEDIR}${DOCSDIR} ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/C.so
${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.for lib in C.so _librsync.so do-test:
${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME:S,-,_,}/${lib} cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m tox
.endfor
koobsUnsubmitted
Done
Inline Actions

Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here

koobs: Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/dev/ral/rt2560.c

# Created by: Gerhard Häring <gh@ghaering.de> # Created by: Gerhard Häring <gh@ghaering.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= rdiff-backup PORTNAME= rdiff-backup
PORTVERSION= 1.2.8 DISTVERSION= 2.0.0
PORTREVISION= 3
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= sysutils CATEGORIES= sysutils python
koobsUnsubmitted
Done
Inline Actions

Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in PyPI)

koobs: Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in…
MASTER_SITES= SAVANNAH \ MASTER_SITES= CHEESESHOP
LOCAL/vd/${PORTNAME}${PKGNAMESUFFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= uzsolt@uzsolt.hu MAINTAINER= uzsolt@uzsolt.hu
COMMENT= Local/remote mirroring+incremental backup COMMENT= Easy to use and efficient backup and restore utility
koobsUnsubmitted
Not Done
Inline Actions

Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible:

in rdiff-backups case: Backup and Restore utility, easy to use, efficient, locally and remotely usable

koobs: Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible: in…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the comments as follows. This is a bit different from what is is the description to not exceed 70 characters limit.

COMMENT=	Easy to use and efficient backup and restore utility
tagattie: Will change the comments as follows. This is a bit different from what is is the description to…
LICENSE= GPLv2 LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
koobsUnsubmitted
Not Done
Inline Actions
  • License stipulated upstream is license="GPLv2+",
  • Add LICENSE_FILE where one is provided with the distribution files. Using github, the file is COPYING. It's also contained in the CHEESESHOP (PyPI) sdist as the same filename
koobs: * License stipulated upstream is license="GPLv2+", * Add LICENSE_FILE where one is provided…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the license block as follows:

LICENSE=	GPLv2+
LICENSE_FILE=	${WRKSRC}/COPYING
tagattie: Will change the license block as follows: ``` LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING…
DEPRECATED= Uses deprecated version of python BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
EXPIRATION_DATE= 2020-09-15
LIB_DEPENDS= librsync.so:net/librsync LIB_DEPENDS= librsync.so:net/librsync
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR}
koobsUnsubmitted
Not Done
Inline Actions

These don't appear to be declared dependencies. Where did they come from?

The only setup_requires I see listed for 2.0.0 is setuptools_scm [1]

[1] setup.py: setup_requires=['setuptools_scm'],

koobs: These don't appear to be declared dependencies. Where did they come from? The only…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those two dependencies and add setuptools_scm to BUILD_DEPENDS.

BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
tagattie: Will delete those two dependencies and add `setuptools_scm` to `BUILD_DEPENDS`. ```…
USES= localbase:ldflags python:3.5+
USE_LDCONFIG= yes
koobsUnsubmitted
Not Done
Inline Actions

Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

koobs: Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to [1] https…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will switch from GITHUB to CHEESESHOP.
Delete:

USE_GITHUB=	yes

Add:

MASTER_SITES=	CHEESESHOP
tagattie: Will switch from GITHUB to CHEESESHOP. Delete: ``` USE_GITHUB= yes ``` Add: ```…
USE_PYTHON= autoplist concurrent distutils
koobsUnsubmitted
Not Done
Inline Actions

Use autoplist unless there's a compelling case note to.

Note also: autoplist can be complemented by a pkg-plist for manual entries

This package appears to install files into common (not python version specific) locations (like /usr/local/bin/) and as such must be made concurrent safe:

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

koobs: Use autoplist unless there's a compelling case note to. Note also: autoplist can be…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change USE_PYTHON as follows:

USE_PYTHON=	autoplist concurrent distutils
tagattie: Will change `USE_PYTHON` as follows: ``` USE_PYTHON= autoplist concurrent distutils ```
CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0* CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0*
koobsUnsubmitted
Not Done
Inline Actions

The other ports mentioned here probably need to be leveled up in the same manner this one does

koobs: The other ports mentioned here probably need to be leveled up in the same manner this one does
tagattieAuthorUnsubmitted
Done
Inline Actions

There is no port named rdiff-backup-devel and this line seems some leftover from the past.

So I guess this line can be removed.

tagattie: There is no port named `rdiff-backup-devel` and this line seems some leftover from the past.
koobsUnsubmitted
Not Done
Inline Actions

This can be removed yeh?

koobs: This can be removed yeh?
tagattieAuthorUnsubmitted
Done
Inline Actions

It seems I was wrong. Those ports may be installed on a machine and may conflict with the current version.
So I would leave the line as it is.

tagattie: It seems I was wrong. Those ports may be installed on a machine and may conflict with the…
PORTSCOUT= limitw:1,even PORTSCOUT= limitw:1,even
USES= python:2.7
USE_PYTHON= distutils
USE_LDCONFIG= yes
MAN1S= rdiff-backup.1 rdiff-backup-statistics.1
DOCS= CHANGELOG README COPYING FAQ.html
OPTIONS_DEFINE= DOCS
post-install: post-install:
koobsUnsubmitted
Not Done
Inline Actions

Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add them to pkg-plist

koobs: Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those 2 lines and let USE_PYTHON=autoplist handle those files.

tagattie: Will delete those 2 lines and let `USE_PYTHON=autoplist` handle those files.
${INSTALL_MAN} ${MAN1S:S,^,${WRKSRC}/,} ${STAGEDIR}${PREFIX}/man/man1 ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/_librsync.so
@${MKDIR} ${STAGEDIR}${DOCSDIR} ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/C.so
${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.for lib in C.so _librsync.so do-test:
${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME:S,-,_,}/${lib} cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m tox
.endfor
koobsUnsubmitted
Done
Inline Actions

Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here

koobs: Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/dev/ral/rt2661.c

# Created by: Gerhard Häring <gh@ghaering.de> # Created by: Gerhard Häring <gh@ghaering.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= rdiff-backup PORTNAME= rdiff-backup
PORTVERSION= 1.2.8 DISTVERSION= 2.0.0
PORTREVISION= 3
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= sysutils CATEGORIES= sysutils python
koobsUnsubmitted
Done
Inline Actions

Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in PyPI)

koobs: Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in…
MASTER_SITES= SAVANNAH \ MASTER_SITES= CHEESESHOP
LOCAL/vd/${PORTNAME}${PKGNAMESUFFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= uzsolt@uzsolt.hu MAINTAINER= uzsolt@uzsolt.hu
COMMENT= Local/remote mirroring+incremental backup COMMENT= Easy to use and efficient backup and restore utility
koobsUnsubmitted
Not Done
Inline Actions

Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible:

in rdiff-backups case: Backup and Restore utility, easy to use, efficient, locally and remotely usable

koobs: Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible: in…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the comments as follows. This is a bit different from what is is the description to not exceed 70 characters limit.

COMMENT=	Easy to use and efficient backup and restore utility
tagattie: Will change the comments as follows. This is a bit different from what is is the description to…
LICENSE= GPLv2 LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
koobsUnsubmitted
Not Done
Inline Actions
  • License stipulated upstream is license="GPLv2+",
  • Add LICENSE_FILE where one is provided with the distribution files. Using github, the file is COPYING. It's also contained in the CHEESESHOP (PyPI) sdist as the same filename
koobs: * License stipulated upstream is license="GPLv2+", * Add LICENSE_FILE where one is provided…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the license block as follows:

LICENSE=	GPLv2+
LICENSE_FILE=	${WRKSRC}/COPYING
tagattie: Will change the license block as follows: ``` LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING…
DEPRECATED= Uses deprecated version of python BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
EXPIRATION_DATE= 2020-09-15
LIB_DEPENDS= librsync.so:net/librsync LIB_DEPENDS= librsync.so:net/librsync
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR}
koobsUnsubmitted
Not Done
Inline Actions

These don't appear to be declared dependencies. Where did they come from?

The only setup_requires I see listed for 2.0.0 is setuptools_scm [1]

[1] setup.py: setup_requires=['setuptools_scm'],

koobs: These don't appear to be declared dependencies. Where did they come from? The only…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those two dependencies and add setuptools_scm to BUILD_DEPENDS.

BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
tagattie: Will delete those two dependencies and add `setuptools_scm` to `BUILD_DEPENDS`. ```…
USES= localbase:ldflags python:3.5+
USE_LDCONFIG= yes
koobsUnsubmitted
Not Done
Inline Actions

Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

koobs: Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to [1] https…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will switch from GITHUB to CHEESESHOP.
Delete:

USE_GITHUB=	yes

Add:

MASTER_SITES=	CHEESESHOP
tagattie: Will switch from GITHUB to CHEESESHOP. Delete: ``` USE_GITHUB= yes ``` Add: ```…
USE_PYTHON= autoplist concurrent distutils
koobsUnsubmitted
Not Done
Inline Actions

Use autoplist unless there's a compelling case note to.

Note also: autoplist can be complemented by a pkg-plist for manual entries

This package appears to install files into common (not python version specific) locations (like /usr/local/bin/) and as such must be made concurrent safe:

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

koobs: Use autoplist unless there's a compelling case note to. Note also: autoplist can be…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change USE_PYTHON as follows:

USE_PYTHON=	autoplist concurrent distutils
tagattie: Will change `USE_PYTHON` as follows: ``` USE_PYTHON= autoplist concurrent distutils ```
CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0* CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0*
koobsUnsubmitted
Not Done
Inline Actions

The other ports mentioned here probably need to be leveled up in the same manner this one does

koobs: The other ports mentioned here probably need to be leveled up in the same manner this one does
tagattieAuthorUnsubmitted
Done
Inline Actions

There is no port named rdiff-backup-devel and this line seems some leftover from the past.

So I guess this line can be removed.

tagattie: There is no port named `rdiff-backup-devel` and this line seems some leftover from the past.
koobsUnsubmitted
Not Done
Inline Actions

This can be removed yeh?

koobs: This can be removed yeh?
tagattieAuthorUnsubmitted
Done
Inline Actions

It seems I was wrong. Those ports may be installed on a machine and may conflict with the current version.
So I would leave the line as it is.

tagattie: It seems I was wrong. Those ports may be installed on a machine and may conflict with the…
PORTSCOUT= limitw:1,even PORTSCOUT= limitw:1,even
USES= python:2.7
USE_PYTHON= distutils
USE_LDCONFIG= yes
MAN1S= rdiff-backup.1 rdiff-backup-statistics.1
DOCS= CHANGELOG README COPYING FAQ.html
OPTIONS_DEFINE= DOCS
post-install: post-install:
koobsUnsubmitted
Not Done
Inline Actions

Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add them to pkg-plist

koobs: Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those 2 lines and let USE_PYTHON=autoplist handle those files.

tagattie: Will delete those 2 lines and let `USE_PYTHON=autoplist` handle those files.
${INSTALL_MAN} ${MAN1S:S,^,${WRKSRC}/,} ${STAGEDIR}${PREFIX}/man/man1 ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/_librsync.so
@${MKDIR} ${STAGEDIR}${DOCSDIR} ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/C.so
${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.for lib in C.so _librsync.so do-test:
${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME:S,-,_,}/${lib} cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m tox
.endfor
koobsUnsubmitted
Done
Inline Actions

Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here

koobs: Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/dev/ral/rt2860.c

# Created by: Gerhard Häring <gh@ghaering.de> # Created by: Gerhard Häring <gh@ghaering.de>
# $FreeBSD$ # $FreeBSD$
PORTNAME= rdiff-backup PORTNAME= rdiff-backup
PORTVERSION= 1.2.8 DISTVERSION= 2.0.0
PORTREVISION= 3
PORTEPOCH= 1 PORTEPOCH= 1
CATEGORIES= sysutils CATEGORIES= sysutils python
koobsUnsubmitted
Done
Inline Actions

Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in PyPI)

koobs: Add 'python' to CATEGORIES as a virtual category (particularly for those packages listed in…
MASTER_SITES= SAVANNAH \ MASTER_SITES= CHEESESHOP
LOCAL/vd/${PORTNAME}${PKGNAMESUFFIX} PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
MAINTAINER= uzsolt@uzsolt.hu MAINTAINER= uzsolt@uzsolt.hu
COMMENT= Local/remote mirroring+incremental backup COMMENT= Easy to use and efficient backup and restore utility
koobsUnsubmitted
Not Done
Inline Actions

Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible:

in rdiff-backups case: Backup and Restore utility, easy to use, efficient, locally and remotely usable

koobs: Set COMMENT to match setup.py:description (modulo portlint/length rules) where possible: in…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the comments as follows. This is a bit different from what is is the description to not exceed 70 characters limit.

COMMENT=	Easy to use and efficient backup and restore utility
tagattie: Will change the comments as follows. This is a bit different from what is is the description to…
LICENSE= GPLv2 LICENSE= GPLv2+
LICENSE_FILE= ${WRKSRC}/COPYING
koobsUnsubmitted
Not Done
Inline Actions
  • License stipulated upstream is license="GPLv2+",
  • Add LICENSE_FILE where one is provided with the distribution files. Using github, the file is COPYING. It's also contained in the CHEESESHOP (PyPI) sdist as the same filename
koobs: * License stipulated upstream is license="GPLv2+", * Add LICENSE_FILE where one is provided…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change the license block as follows:

LICENSE=	GPLv2+
LICENSE_FILE=	${WRKSRC}/COPYING
tagattie: Will change the license block as follows: ``` LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING…
DEPRECATED= Uses deprecated version of python BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
EXPIRATION_DATE= 2020-09-15
LIB_DEPENDS= librsync.so:net/librsync LIB_DEPENDS= librsync.so:net/librsync
TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}tox>0:devel/py-tox@${PY_FLAVOR}
koobsUnsubmitted
Not Done
Inline Actions

These don't appear to be declared dependencies. Where did they come from?

The only setup_requires I see listed for 2.0.0 is setuptools_scm [1]

[1] setup.py: setup_requires=['setuptools_scm'],

koobs: These don't appear to be declared dependencies. Where did they come from? The only…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those two dependencies and add setuptools_scm to BUILD_DEPENDS.

BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR}
tagattie: Will delete those two dependencies and add `setuptools_scm` to `BUILD_DEPENDS`. ```…
USES= localbase:ldflags python:3.5+
USE_LDCONFIG= yes
koobsUnsubmitted
Not Done
Inline Actions

Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to

[1] https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

koobs: Use CHEESESHOP (PyPI) for MASTER_SITES unless there is a compelling reason not to [1] https…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will switch from GITHUB to CHEESESHOP.
Delete:

USE_GITHUB=	yes

Add:

MASTER_SITES=	CHEESESHOP
tagattie: Will switch from GITHUB to CHEESESHOP. Delete: ``` USE_GITHUB= yes ``` Add: ```…
USE_PYTHON= autoplist concurrent distutils
koobsUnsubmitted
Not Done
Inline Actions

Use autoplist unless there's a compelling case note to.

Note also: autoplist can be complemented by a pkg-plist for manual entries

This package appears to install files into common (not python version specific) locations (like /usr/local/bin/) and as such must be made concurrent safe:

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

koobs: Use autoplist unless there's a compelling case note to. Note also: autoplist can be…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will change USE_PYTHON as follows:

USE_PYTHON=	autoplist concurrent distutils
tagattie: Will change `USE_PYTHON` as follows: ``` USE_PYTHON= autoplist concurrent distutils ```
CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0* CONFLICTS= rdiff-backup-devel-[0-9]* rdiff-backup-1.0*
koobsUnsubmitted
Not Done
Inline Actions

The other ports mentioned here probably need to be leveled up in the same manner this one does

koobs: The other ports mentioned here probably need to be leveled up in the same manner this one does
tagattieAuthorUnsubmitted
Done
Inline Actions

There is no port named rdiff-backup-devel and this line seems some leftover from the past.

So I guess this line can be removed.

tagattie: There is no port named `rdiff-backup-devel` and this line seems some leftover from the past.
koobsUnsubmitted
Not Done
Inline Actions

This can be removed yeh?

koobs: This can be removed yeh?
tagattieAuthorUnsubmitted
Done
Inline Actions

It seems I was wrong. Those ports may be installed on a machine and may conflict with the current version.
So I would leave the line as it is.

tagattie: It seems I was wrong. Those ports may be installed on a machine and may conflict with the…
PORTSCOUT= limitw:1,even PORTSCOUT= limitw:1,even
USES= python:2.7
USE_PYTHON= distutils
USE_LDCONFIG= yes
MAN1S= rdiff-backup.1 rdiff-backup-statistics.1
DOCS= CHANGELOG README COPYING FAQ.html
OPTIONS_DEFINE= DOCS
post-install: post-install:
koobsUnsubmitted
Not Done
Inline Actions

Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add them to pkg-plist

koobs: Likely handled already (not needed) with USE_PYTHON=autoplist, if not leave them here or add…
tagattieAuthorUnsubmitted
Done
Inline Actions

Will delete those 2 lines and let USE_PYTHON=autoplist handle those files.

tagattie: Will delete those 2 lines and let `USE_PYTHON=autoplist` handle those files.
${INSTALL_MAN} ${MAN1S:S,^,${WRKSRC}/,} ${STAGEDIR}${PREFIX}/man/man1 ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/_librsync.so
@${MKDIR} ${STAGEDIR}${DOCSDIR} ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/rdiff_backup/C.so
${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
.for lib in C.so _librsync.so do-test:
${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/${PORTNAME:S,-,_,}/${lib} cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m tox
.endfor
koobsUnsubmitted
Done
Inline Actions

Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here

koobs: Use prefix-safe PYTHONPREFIX_SITELIBDIR variable here
.include <bsd.port.mk> .include <bsd.port.mk>
View Options

head/sys/dev/usb/wlan/if_rum.c

Loading...
View Options

head/sys/dev/usb/wlan/if_run.c

Loading...
View Options

head/sys/dev/usb/wlan/if_ural.c

Loading...
View Options

head/sys/dev/wpi/if_wpi.c

Loading...
View Options

head/sys/dev/wtap/if_wtap.c

Loading...
View Options

head/sys/net80211/ieee80211_output.c

Loading...
View Options

head/sys/net80211/ieee80211_proto.h

Loading...