amd64 efirt: initialize vm_pages backing EFI runtime memory
ClosedPublic
Actions

Authored by kib on Jun 16 2021, 2:01 AM.

Details

Reviewers

Commits

rG0247c33e89ad: amd64 efirt: initialize vm_pages backing EFI runtime memory
rG5b10e79edba5: Un-staticise vm_page_init_page()

Summary

so that PHYS_TO_VM_PAGE() and consequently physcopyin() work for them

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib requested review of this revision.Jun 16 2021, 2:01 AM

kib created this revision.

kib mentioned this in D30104: efirt: add ESRT table support.

kib edited the summary of this revision. (Show Details)Jun 16 2021, 9:10 PM

kib added a reviewer: markj.

markj added inline comments.Jun 16 2021, 9:28 PM

sys/amd64/amd64/efirt_machdep.c
252	`p->md_phys + ptoa(idx)` can be written as `va`, or is it intentional? I guess `PHYS_TO_VM_PAGE(va)` looks a bit suspicious.
258	I don't understand the purpose of introducing vm_page_init_page_partial() if you're going to manually override these fields anyway.

I considered initializing m->phys_addr for all pages in vm_page_array[]. I decided to not do it for this change because I set up other attributes, the mode is most important. But I think it is useful to have VM_PAGE_TO_PHYS/PHYS_TO_VM_PAGE to work somehow for low addresses.