devel/py-bitstring: Update to 3.1.7
ClosedPublic
Actions

Authored by loader on Jun 5 2021, 7:04 AM.

Details

Reviewers

koobs
sbz

Commits

R11:d15ad74bd29d: devel/py-bitstring: Update to 3.1.7

Summary

devel/py-bitstring: Update to 3.1.7

- Update to 3.1.7
- The sdist on PyPI changed from .zip to .tar.gz
- Add NO_ARCH

Reviewed_by:	koobs, sbz
Approved by:	koobs (ports, mentor, implicit), sbz (maintainer)
Differential_Revision: D30651
MFH:		No (feature release)

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 140013, [armv7,aarch64,i386,amd64], tested)
unittest: OK (

tested on aarch64:
Python3.6: Ran 12 tests in 0.120s
Python3.7: Ran 12 tests in 0.112s
Python3.8: Ran 12 tests in 0.110s
Python3.9: Ran 12 tests in 0.112s
)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

loader created this revision.Jun 5 2021, 7:04 AM

Herald added a subscriber: mat. · View Herald TranscriptJun 5 2021, 7:04 AM

loader requested review of this revision.Jun 5 2021, 7:04 AM

Harbormaster completed remote builds in B39723: Diff 90440.Jun 5 2021, 7:04 AM

loader edited the summary of this revision. (Show Details)Jun 5 2021, 7:07 AM

sbz accepted this revision.Jun 9 2021, 9:53 PM

This revision is now accepted and ready to land.Jun 9 2021, 9:53 PM

Thanks @loader, just a minor nit in your commit message, it should be (full URL and no underscore for tags):

Differential Revision:        https://reviews.freebsd.org/D30651

Also you don't need the MFH tag.

In D30651#690197, @sbz wrote:
Thanks @loader, just a minor nit in your commit message, it should be (full URL and no underscore for tags):
Differential Revision:        https://reviews.freebsd.org/D30651

Underscore is there because phabricator parses it, even within ` ` tags.

Also you don't need the MFH tag.

I've asked for MFH tags, because explicit > implicit, especially with regards to reasons why, or why not (in particular), a change was or wasnt merged. Part of commit commit log message standards.

koobs edited the summary of this revision. (Show Details)Jun 10 2021, 12:42 AM

Thanks @koobs, @sbz.