Page MenuHomeFreeBSD
Differential D30659

net/libwebsockets: Update to 4.2.0
AbandonedPublic
Actions

Authored by otis on Jun 6 2021, 2:27 PM.
Tags
None
Referenced Files
F106054028: D30659.diff
Tue, Dec 24, 2:35 PM
Unknown Object (File)
Fri, Dec 20, 6:18 PM
Unknown Object (File)
Fri, Dec 20, 5:34 PM
Unknown Object (File)
Fri, Dec 20, 5:33 PM
Unknown Object (File)
Wed, Nov 27, 9:46 PM
Unknown Object (File)
Nov 15 2024, 6:20 PM
Unknown Object (File)
Nov 9 2024, 5:38 AM
Unknown Object (File)
Nov 7 2024, 10:15 PM
View All 75 Files
Subscribers
mat

Details

Reviewers
diizzy
Summary
  • Update libwebsockets to 4.2.0
  • Enable mqtt support by default
  • "Hack" around hard git requirement

PR: 256019

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39745
Build 36634: arc lint + arc unit

Event Timeline

otis created this revision.Jun 6 2021, 2:27 PM
Herald added a subscriber: mat. · View Herald TranscriptJun 6 2021, 2:27 PM
otis requested review of this revision.Jun 6 2021, 2:27 PM
Harbormaster completed remote builds in B39744: Diff 90481.Jun 6 2021, 2:27 PM
otis updated this revision to Diff 90482.Jun 6 2021, 2:29 PM

Remove now-unneeded post-patch

Harbormaster completed remote builds in B39745: Diff 90482.Jun 6 2021, 2:29 PM
otis updated this revision to Diff 90484.Jun 6 2021, 2:55 PM

Set cmake arg as string

Harbormaster completed remote builds in B39746: Diff 90484.Jun 6 2021, 2:55 PM
diizzy accepted this revision.Jun 6 2021, 5:17 PM

LGTM

This revision is now accepted and ready to land.Jun 6 2021, 5:17 PM
diizzy added a comment.EditedJun 6 2021, 5:22 PM

It's fine except for the rearrgement of which is bad, it's not presented like that, makes it harder to read and understand what's going on.

If anything, HTTP2 and HTTP_PROXY should trade places and "WolfSSL need" should be "WolfSSL needs".

otis updated this revision to Diff 90491.Jun 6 2021, 8:29 PM

Only set LWS_BUILD_HASH

This revision now requires review to proceed.Jun 6 2021, 8:29 PM
Harbormaster completed remote builds in B39750: Diff 90491.Jun 6 2021, 8:29 PM
otis updated this revision to Diff 90492.Jun 6 2021, 8:30 PM

Use proper variable name

Harbormaster completed remote builds in B39751: Diff 90492.Jun 6 2021, 8:30 PM
diizzy added a comment.Jun 9 2021, 1:29 PM

@otis
You can close this now

diizzy added a comment.Jun 9 2021, 1:30 PM

...and this too :-)

otis abandoned this revision.Jun 9 2021, 1:41 PM

Committed, thanks.

Revision Contents
Changeset List

PathSize
net/
libwebsockets/
89 lines

Diff 90482

View Options

net/libwebsockets/Makefile

Loading...