Page MenuHomeFreeBSD
Differential D3730

Add new port: devel/myrepos.
ClosedPublic
Actions

Authored by jonathan on Sep 24 2015, 5:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 2:29 AM
Unknown Object (File)
Fri, Apr 4, 7:40 PM
Unknown Object (File)
Thu, Mar 20, 3:32 AM
Unknown Object (File)
Mar 8 2025, 12:15 AM
Unknown Object (File)
Mar 6 2025, 1:24 PM
Unknown Object (File)
Feb 25 2025, 5:00 PM
Unknown Object (File)
Feb 22 2025, 11:26 AM
Unknown Object (File)
Feb 18 2025, 10:37 PM
View All Files
Subscribers
brooks
garga

Details

Reviewers
brooks
garga
Commits
rP400363: Add new port: devel/libdistance.
Summary

This is a handy Perl script for managing directory hierarchies that contain
lots of heterogeneous revision control checkouts. It's packaged for Debian
and Mac OS X (via Homebrew)... how about FreeBSD?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 602
Build 602: arc lint + arc unit

Event Timeline

jonathan updated this revision to Diff 8924.Sep 24 2015, 5:34 PM
jonathan retitled this revision from to Add new port: devel/myrepos..
jonathan updated this object.
jonathan edited the test plan for this revision. (Show Details)
jonathan updated this revision to Diff 9743.Oct 27 2015, 7:10 PM
  • Add new port: devel/myrepos.
  • Minor changes suggested by portlint -A.
garga requested changes to this revision.Oct 27 2015, 7:15 PM
garga added a reviewer: garga.
garga added a subscriber: garga.

shebangfix is the best option to take care of shebang lines

devel/myrepos/files/patch-mr
6

You can use USES=shebangfix to take care of it

This revision now requires changes to proceed.Oct 27 2015, 7:15 PM
brooks added a subscriber: brooks.Oct 27 2015, 7:17 PM
brooks added inline comments.
devel/myrepos/Makefile
23

You can define NO_BUILD instead.

devel/myrepos/files/patch-mr
6

Instead, add to the Makefile:

USES=shebangfix
SHEBANG_FILES=mr

jonathan updated this revision to Diff 9744.Oct 27 2015, 8:03 PM
jonathan edited edge metadata.
jonathan marked 3 inline comments as done.
  • Apply changes suggested by reviewers.
brooks accepted this revision.Oct 27 2015, 10:24 PM
brooks added a reviewer: brooks.

Looks good to me.

Closed by commit rP400363: Add new port: devel/libdistance. (authored by jonathan). · Explain WhyOct 28 2015, 12:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
myrepos/
29 lines
2 lines
files/
8 lines
31 lines

Diff 8924

View Options

devel/myrepos/Makefile

Show First 20 Lines • Show All 727 Lines • ▼ Show 20 Lines if (IN_LOOPBACK(ntohl(ip->ip_dst.s_addr)) ||
IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) { IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) {
if ((ifp->if_flags & IFF_LOOPBACK) == 0) { if ((ifp->if_flags & IFF_LOOPBACK) == 0) {
IPSTAT_INC(ips_badaddr); IPSTAT_INC(ips_badaddr);
error = EADDRNOTAVAIL; error = EADDRNOTAVAIL;
goto bad; goto bad;
} }
} }
m->m_pkthdr.csum_flags |= CSUM_IP; /* Ensure the packet data is mapped if the interface requires it. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) { if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
m = mb_unmapped_to_ext(m); m = mb_unmapped_to_ext(m);
if (m == NULL) { if (m == NULL) {
IPSTAT_INC(ips_odropped); IPSTAT_INC(ips_odropped);
error = ENOBUFS; error = ENOBUFS;
goto bad; goto bad;
} }
}
m->m_pkthdr.csum_flags |= CSUM_IP;
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) {
in_delayed_cksum(m); in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} else if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
jhbUnsubmitted
Done
Inline Actions

This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload disabled as we will not fall through to the else. I think the IFCAP_MEXTPG check now needs to just be its own check. If it makes the checksum calculations more optimal we should perhaps do it before doing the checksums.

jhb: This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload…
markjAuthorUnsubmitted
Done
Inline Actions

Oops, thanks. I realized this when writing the patch but forgot to actually do something about it. :(

I guess m_apply() is a bit cheaper for non-extpg mbufs, so it makes some sense to do that first.

markj: Oops, thanks. I realized this when writing the patch but forgot to actually do something about…
m = mb_unmapped_to_ext(m);
if (m == NULL) {
IPSTAT_INC(ips_odropped);
error = ENOBUFS;
goto bad;
} }
}
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) { if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) {
sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2)); sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2));
m->m_pkthdr.csum_flags &= ~CSUM_SCTP; m->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
#endif #endif
/* /*
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Linesip_fragment(struct ip *ip, struct mbuf **m_frag, int mtu,
if (len < 8) if (len < 8)
return EMSGSIZE; return EMSGSIZE;
/* /*
* If the interface will not calculate checksums on * If the interface will not calculate checksums on
* fragmented packets, then do it here. * fragmented packets, then do it here.
*/ */
if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) { if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
m0 = mb_unmapped_to_ext(m0);
if (m0 == NULL) {
error = ENOBUFS;
IPSTAT_INC(ips_odropped);
goto done;
}
in_delayed_cksum(m0); in_delayed_cksum(m0);
m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} }
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m0->m_pkthdr.csum_flags & CSUM_SCTP) { if (m0->m_pkthdr.csum_flags & CSUM_SCTP) {
sctp_delayed_cksum(m0, hlen); sctp_delayed_cksum(m0, hlen);
m0->m_pkthdr.csum_flags &= ~CSUM_SCTP; m0->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
▲ Show 20 Lines • Show All 703 Lines • Show Last 20 Lines
View Options

devel/myrepos/distinfo

Show First 20 Lines • Show All 727 Lines • ▼ Show 20 Lines if (IN_LOOPBACK(ntohl(ip->ip_dst.s_addr)) ||
IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) { IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) {
if ((ifp->if_flags & IFF_LOOPBACK) == 0) { if ((ifp->if_flags & IFF_LOOPBACK) == 0) {
IPSTAT_INC(ips_badaddr); IPSTAT_INC(ips_badaddr);
error = EADDRNOTAVAIL; error = EADDRNOTAVAIL;
goto bad; goto bad;
} }
} }
m->m_pkthdr.csum_flags |= CSUM_IP; /* Ensure the packet data is mapped if the interface requires it. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) { if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
m = mb_unmapped_to_ext(m); m = mb_unmapped_to_ext(m);
if (m == NULL) { if (m == NULL) {
IPSTAT_INC(ips_odropped); IPSTAT_INC(ips_odropped);
error = ENOBUFS; error = ENOBUFS;
goto bad; goto bad;
} }
}
m->m_pkthdr.csum_flags |= CSUM_IP;
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) {
in_delayed_cksum(m); in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} else if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
jhbUnsubmitted
Done
Inline Actions

This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload disabled as we will not fall through to the else. I think the IFCAP_MEXTPG check now needs to just be its own check. If it makes the checksum calculations more optimal we should perhaps do it before doing the checksums.

jhb: This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload…
markjAuthorUnsubmitted
Done
Inline Actions

Oops, thanks. I realized this when writing the patch but forgot to actually do something about it. :(

I guess m_apply() is a bit cheaper for non-extpg mbufs, so it makes some sense to do that first.

markj: Oops, thanks. I realized this when writing the patch but forgot to actually do something about…
m = mb_unmapped_to_ext(m);
if (m == NULL) {
IPSTAT_INC(ips_odropped);
error = ENOBUFS;
goto bad;
} }
}
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) { if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) {
sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2)); sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2));
m->m_pkthdr.csum_flags &= ~CSUM_SCTP; m->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
#endif #endif
/* /*
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Linesip_fragment(struct ip *ip, struct mbuf **m_frag, int mtu,
if (len < 8) if (len < 8)
return EMSGSIZE; return EMSGSIZE;
/* /*
* If the interface will not calculate checksums on * If the interface will not calculate checksums on
* fragmented packets, then do it here. * fragmented packets, then do it here.
*/ */
if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) { if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
m0 = mb_unmapped_to_ext(m0);
if (m0 == NULL) {
error = ENOBUFS;
IPSTAT_INC(ips_odropped);
goto done;
}
in_delayed_cksum(m0); in_delayed_cksum(m0);
m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} }
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m0->m_pkthdr.csum_flags & CSUM_SCTP) { if (m0->m_pkthdr.csum_flags & CSUM_SCTP) {
sctp_delayed_cksum(m0, hlen); sctp_delayed_cksum(m0, hlen);
m0->m_pkthdr.csum_flags &= ~CSUM_SCTP; m0->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
▲ Show 20 Lines • Show All 703 Lines • Show Last 20 Lines
View Options

devel/myrepos/files/patch-mr

Show First 20 Lines • Show All 727 Lines • ▼ Show 20 Lines if (IN_LOOPBACK(ntohl(ip->ip_dst.s_addr)) ||
IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) { IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) {
if ((ifp->if_flags & IFF_LOOPBACK) == 0) { if ((ifp->if_flags & IFF_LOOPBACK) == 0) {
IPSTAT_INC(ips_badaddr); IPSTAT_INC(ips_badaddr);
error = EADDRNOTAVAIL; error = EADDRNOTAVAIL;
goto bad; goto bad;
} }
} }
m->m_pkthdr.csum_flags |= CSUM_IP; /* Ensure the packet data is mapped if the interface requires it. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) { if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
m = mb_unmapped_to_ext(m); m = mb_unmapped_to_ext(m);
if (m == NULL) { if (m == NULL) {
IPSTAT_INC(ips_odropped); IPSTAT_INC(ips_odropped);
error = ENOBUFS; error = ENOBUFS;
goto bad; goto bad;
} }
}
m->m_pkthdr.csum_flags |= CSUM_IP;
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) {
in_delayed_cksum(m); in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} else if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
jhbUnsubmitted
Done
Inline Actions

This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload disabled as we will not fall through to the else. I think the IFCAP_MEXTPG check now needs to just be its own check. If it makes the checksum calculations more optimal we should perhaps do it before doing the checksums.

jhb: This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload…
markjAuthorUnsubmitted
Done
Inline Actions

Oops, thanks. I realized this when writing the patch but forgot to actually do something about it. :(

I guess m_apply() is a bit cheaper for non-extpg mbufs, so it makes some sense to do that first.

markj: Oops, thanks. I realized this when writing the patch but forgot to actually do something about…
m = mb_unmapped_to_ext(m);
if (m == NULL) {
IPSTAT_INC(ips_odropped);
error = ENOBUFS;
goto bad;
} }
}
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) { if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) {
sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2)); sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2));
m->m_pkthdr.csum_flags &= ~CSUM_SCTP; m->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
#endif #endif
/* /*
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Linesip_fragment(struct ip *ip, struct mbuf **m_frag, int mtu,
if (len < 8) if (len < 8)
return EMSGSIZE; return EMSGSIZE;
/* /*
* If the interface will not calculate checksums on * If the interface will not calculate checksums on
* fragmented packets, then do it here. * fragmented packets, then do it here.
*/ */
if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) { if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
m0 = mb_unmapped_to_ext(m0);
if (m0 == NULL) {
error = ENOBUFS;
IPSTAT_INC(ips_odropped);
goto done;
}
in_delayed_cksum(m0); in_delayed_cksum(m0);
m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} }
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m0->m_pkthdr.csum_flags & CSUM_SCTP) { if (m0->m_pkthdr.csum_flags & CSUM_SCTP) {
sctp_delayed_cksum(m0, hlen); sctp_delayed_cksum(m0, hlen);
m0->m_pkthdr.csum_flags &= ~CSUM_SCTP; m0->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
▲ Show 20 Lines • Show All 703 Lines • Show Last 20 Lines
View Options

devel/myrepos/pkg-descr

Show First 20 Lines • Show All 727 Lines • ▼ Show 20 Lines if (IN_LOOPBACK(ntohl(ip->ip_dst.s_addr)) ||
IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) { IN_LOOPBACK(ntohl(ip->ip_src.s_addr))) {
if ((ifp->if_flags & IFF_LOOPBACK) == 0) { if ((ifp->if_flags & IFF_LOOPBACK) == 0) {
IPSTAT_INC(ips_badaddr); IPSTAT_INC(ips_badaddr);
error = EADDRNOTAVAIL; error = EADDRNOTAVAIL;
goto bad; goto bad;
} }
} }
m->m_pkthdr.csum_flags |= CSUM_IP; /* Ensure the packet data is mapped if the interface requires it. */
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) { if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
m = mb_unmapped_to_ext(m); m = mb_unmapped_to_ext(m);
if (m == NULL) { if (m == NULL) {
IPSTAT_INC(ips_odropped); IPSTAT_INC(ips_odropped);
error = ENOBUFS; error = ENOBUFS;
goto bad; goto bad;
} }
}
m->m_pkthdr.csum_flags |= CSUM_IP;
if (m->m_pkthdr.csum_flags & CSUM_DELAY_DATA & ~ifp->if_hwassist) {
in_delayed_cksum(m); in_delayed_cksum(m);
m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} else if ((ifp->if_capenable & IFCAP_MEXTPG) == 0) {
jhbUnsubmitted
Done
Inline Actions

This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload disabled as we will not fall through to the else. I think the IFCAP_MEXTPG check now needs to just be its own check. If it makes the checksum calculations more optimal we should perhaps do it before doing the checksums.

jhb: This is now broken for an interface that doesn't support IFCAP_MEXTPG and has checksum offload…
markjAuthorUnsubmitted
Done
Inline Actions

Oops, thanks. I realized this when writing the patch but forgot to actually do something about it. :(

I guess m_apply() is a bit cheaper for non-extpg mbufs, so it makes some sense to do that first.

markj: Oops, thanks. I realized this when writing the patch but forgot to actually do something about…
m = mb_unmapped_to_ext(m);
if (m == NULL) {
IPSTAT_INC(ips_odropped);
error = ENOBUFS;
goto bad;
} }
}
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) { if (m->m_pkthdr.csum_flags & CSUM_SCTP & ~ifp->if_hwassist) {
sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2)); sctp_delayed_cksum(m, (uint32_t)(ip->ip_hl << 2));
m->m_pkthdr.csum_flags &= ~CSUM_SCTP; m->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
#endif #endif
/* /*
▲ Show 20 Lines • Show All 127 Lines • ▼ Show 20 Linesip_fragment(struct ip *ip, struct mbuf **m_frag, int mtu,
if (len < 8) if (len < 8)
return EMSGSIZE; return EMSGSIZE;
/* /*
* If the interface will not calculate checksums on * If the interface will not calculate checksums on
* fragmented packets, then do it here. * fragmented packets, then do it here.
*/ */
if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) { if (m0->m_pkthdr.csum_flags & CSUM_DELAY_DATA) {
m0 = mb_unmapped_to_ext(m0);
if (m0 == NULL) {
error = ENOBUFS;
IPSTAT_INC(ips_odropped);
goto done;
}
in_delayed_cksum(m0); in_delayed_cksum(m0);
m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA; m0->m_pkthdr.csum_flags &= ~CSUM_DELAY_DATA;
} }
#if defined(SCTP) || defined(SCTP_SUPPORT) #if defined(SCTP) || defined(SCTP_SUPPORT)
if (m0->m_pkthdr.csum_flags & CSUM_SCTP) { if (m0->m_pkthdr.csum_flags & CSUM_SCTP) {
sctp_delayed_cksum(m0, hlen); sctp_delayed_cksum(m0, hlen);
m0->m_pkthdr.csum_flags &= ~CSUM_SCTP; m0->m_pkthdr.csum_flags &= ~CSUM_SCTP;
} }
▲ Show 20 Lines • Show All 703 Lines • Show Last 20 Lines