Differential D3705

net80211 & wireless drivers: remove duplicate defines (noop)
ClosedPublic
Actions

Authored by avos on Sep 21 2015, 4:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 5, 12:30 AM

	Unknown Object (File)
	Wed, Dec 31, 8:14 PM

	Unknown Object (File)
	Thu, Dec 25, 5:33 PM

	Unknown Object (File)
	Wed, Dec 24, 11:06 AM

	Unknown Object (File)
	Sun, Dec 14, 3:52 AM

	Unknown Object (File)
	Dec 13 2025, 3:14 AM

	Unknown Object (File)
	Nov 28 2025, 8:26 AM

	Unknown Object (File)
	Nov 27 2025, 11:57 PM

Subscribers

Details

Reviewers

Commits

rS288088: net80211 & wireless drivers: remove duplicate defines (noop)
rS288087: net80211 & wireless drivers: remove duplicate defines (noop)
rS288086: Remove duplicate use of RV(), LE_* and other macros.
rS288084: Define a rateval macro that drivers tend to hard-code.

Summary

IEEE80211_DIR_DSTODS(wh) -> IEEE80211_IS_DSTODS(wh).
N(a) -> nitems(a).
Remove LE_READ_2(p)/LE_READ_4(p) definitions (and include ieee80211_input.h instead).
<drvname>_TXOP_TO_US(txop) -> IEEE80211_TXOP_TO_US(txop).
Put IEEE80211_RV(v) into ieee80211_proto.h and remove local RV(v) definitions.

Test Plan

Tested with 'make buildkernel'.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 8863.Sep 21 2015, 4:17 PM

avos retitled this revision from to net80211 & wireless drivers: remove duplicate defines (noop).

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptSep 21 2015, 4:17 PM

looks good; I'll commit it tonight. Thanks!

This revision is now accepted and ready to land.Sep 22 2015, 12:17 AM

Closed by commit rS288084: Define a rateval macro that drivers tend to hard-code. (authored by adrian). · Explain WhySep 22 2015, 2:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ath/

22 lines

if_ath_keycache.c

16 lines

bwi/

6 lines

30 lines

7 lines

12 lines

ipw/

4 lines

iwi/

8 lines

iwn/

10 lines

malo/

19 lines

4 lines

mwl/

33 lines

ral/

13 lines

15 lines

5 lines

usb/

wlan/

16 lines

1 line

8 lines

27 lines

4 lines

4 lines

108 lines

net80211/

1 line

6 lines

ieee80211_mesh.c

10 lines

ieee80211_proto.c

7 lines

ieee80211_scan_sta.c

14 lines

Diff 8863

sys/dev/ath/if_ath.c

Loading...

sys/dev/ath/if_ath_keycache.c

Loading...

sys/dev/bwi/bwimac.c

Loading...

sys/dev/bwi/bwiphy.c

Loading...

sys/dev/bwi/bwirf.c

Loading...

sys/dev/bwi/if_bwi.c

Loading...

sys/dev/ipw/if_ipw.c

Loading...

sys/dev/iwi/if_iwi.c

Loading...

sys/dev/iwn/if_iwn.c

Loading...

sys/dev/malo/if_malo.c

Loading...

sys/dev/malo/if_malo_pci.c

Loading...

sys/dev/mwl/if_mwl.c

Loading...

sys/dev/ral/rt2560.c

Loading...

sys/dev/ral/rt2661.c

Loading...

sys/dev/ral/rt2860.c

Loading...

sys/dev/usb/wlan/if_uath.c

Loading...

sys/dev/usb/wlan/if_uathvar.h

Loading...

sys/dev/usb/wlan/if_ural.c

Loading...

sys/dev/usb/wlan/if_urtw.c

Loading...

sys/dev/usb/wlan/if_urtwn.c

Loading...

sys/dev/usb/wlan/if_urtwnreg.h

Loading...

sys/dev/usb/wlan/if_zyd.c

Loading...

sys/net80211/ieee80211.h

Loading...

sys/net80211/ieee80211_ht.c

Loading...

sys/net80211/ieee80211_mesh.c

Loading...

sys/net80211/ieee80211_proto.c

Loading...

sys/net80211/ieee80211_scan_sta.c

Loading...