Page MenuHomeFreeBSD
Differential D29973

books/porters-handbook: Include fish-shell completions path
ClosedPublic
Actions

Authored by lcook on Apr 25 2021, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 18, 5:43 PM
Unknown Object (File)
Sun, Dec 14, 10:03 PM
Unknown Object (File)
Thu, Nov 27, 10:42 AM
Unknown Object (File)
Nov 11 2025, 10:32 PM
Unknown Object (File)
Nov 5 2025, 11:39 PM
Unknown Object (File)
Nov 5 2025, 9:47 PM
Unknown Object (File)
Oct 18 2025, 10:35 AM
Unknown Object (File)
Oct 17 2025, 6:35 PM
View All Files
Subscribers
0mp
ygy

Details

Reviewers
0mp
ygy
Group Reviewers
Doc Committers
Commits
R9:cc7b0877fbd2: books/porters-handbook: Include fish-shell completion path
Summary

Simple patch to note where to install vendored fish shell completions correctly
and not pollute the upstream (shells/fish) provided completions. This helps
avoid situations as I had earlier, seen in PR255384.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38853
Build 35742: arc lint + arc unit

Event Timeline

lcook requested review of this revision.Apr 25 2021, 4:10 PM
lcook created this revision.
Harbormaster completed remote builds in B38853: Diff 88119.Apr 25 2021, 4:11 PM
lcook edited the summary of this revision. (Show Details)Apr 25 2021, 4:12 PM
lcook added a reviewer: Doc Committers.
0mp requested changes to this revision.Apr 26 2021, 2:10 PM
0mp added a subscriber: 0mp.
0mp added inline comments.
documentation/content/en/books/porters-handbook/special/_index.adoc
4310

I'd keep this list sorted (that is, put fish between bash and tcsh).

4324

Let's put it between bash and zsh to keep the table entries in order.

This revision now requires changes to proceed.Apr 26 2021, 2:10 PM
lcook updated this revision to Diff 88338.Apr 28 2021, 5:15 PM

Sort shell listings

Harbormaster completed remote builds in B38915: Diff 88338.Apr 28 2021, 5:16 PM
lcook marked 2 inline comments as done.Apr 28 2021, 5:16 PM

Thanks :)

ygy accepted this revision as: ygy.Apr 29 2021, 5:27 AM
ygy added a subscriber: ygy.

Looks good to me!

0mp accepted this revision.Apr 29 2021, 8:56 AM

Thanks!

This revision is now accepted and ready to land.Apr 29 2021, 8:56 AM
Closed by commit R9:cc7b0877fbd2: books/porters-handbook: Include fish-shell completion path (authored by lcook). · Explain WhyApr 29 2021, 2:25 PM
This revision was automatically updated to reflect the committed changes.
lcook added a commit: R9:cc7b0877fbd2: books/porters-handbook: Include fish-shell completion path.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
special/
5 lines

Diff 88119

View Options

documentation/content/en/books/porters-handbook/special/_index.adoc

Loading...