Differential D29930

Add chr/blk devices support.
ClosedPublic
Actions

Authored by fsu on Apr 22 2021, 5:25 PM.

Details

Reviewers

pfg

Commits

rG1ed5f62d61ac: Add chr/blk devices support.

Summary

Device major/minor values conversion to/from linux ext4 compatible format happen during on-disk inodes writing/reading.

Test Plan

This change makes happy bunch of pjdfstest testcases.
Also, major/minor values equality checked on linux side thru shared iSCSI target.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fsu requested review of this revision.Apr 22 2021, 5:25 PM

fsu created this revision.

LGTM

sys/fs/ext2fs/ext2_inode_cnv.c
99	Shouldn't all these be inline?

This revision is now accepted and ready to land.Apr 22 2021, 8:54 PM

Make functions inline

This revision now requires review to proceed.Apr 23 2021, 2:37 PM

pfg accepted this revision.Apr 23 2021, 4:07 PM

This revision is now accepted and ready to land.Apr 23 2021, 4:07 PM

Closed by commit rG1ed5f62d61ac: Add chr/blk devices support. (authored by fsu). · Explain WhyMay 7 2021, 7:10 AM

This revision was automatically updated to reflect the committed changes.

fsu added a commit: rG1ed5f62d61ac: Add chr/blk devices support..

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

3 lines

54 lines

32 lines

7 lines

2 lines

Diff 88044

View Options

sys/fs/ext2fs/ext2_inode.c

View Options

sys/fs/ext2fs/ext2_inode_cnv.c

View Options

sys/fs/ext2fs/ext2_vnops.c

View Options

sys/fs/ext2fs/ext2fs.h

View Options

Add chr/blk devices support.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 88044

sys/fs/ext2fs/ext2_inode.c

sys/fs/ext2fs/ext2_inode_cnv.c

sys/fs/ext2fs/ext2_vnops.c

sys/fs/ext2fs/ext2fs.h

sys/fs/ext2fs/inode.h

Add chr/blk devices support.
ClosedPublic
Actions

Revision Contents
Changeset List