Differential D29793

Update graphics/cario to 1.17.4
ClosedPublic
Actions

Authored by nc on Apr 16 2021, 2:52 PM.

Details

Reviewers: None
Commits: R11:dbca720cdec9: graphics/cario: Update to 1.17.4

Summary

Update graphics/cario to 1.17.4

Test Plan

Passes poudriere, tested to work

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 38630
Build 35519: arc lint + arc unit

Event Timeline

nc created this revision.Apr 16 2021, 2:52 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 16 2021, 2:52 PM

nc requested review of this revision.Apr 16 2021, 2:52 PM

Harbormaster completed remote builds in B38620: Diff 87549.Apr 16 2021, 2:52 PM

nc mentioned this in D29784: Import GTK 4 to the FreeBSD Ports tree.Apr 16 2021, 2:53 PM

Please switch to Meson if we're going to bump it.
You also need to verify the reason why we had to revert last time.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249290

graphics/cairo/Makefile
4	DISTVERSION
14	not + https://docs.freebsd.org/en/books/porters-handbook/book.html ( Section 5.4.8 ) Perhaps be a bit more descriptive, like "Generate cairo-script-interpreter.pc" We've also been bitten before where patches change regarding Gitlab so I think it's still preferred to have it in files despite not following the "normal" patch convention.

Heh, apparently Phab doesn't like some non quoted syntax ;-)

diizzy added inline comments.Apr 16 2021, 7:05 PM

graphics/cairo/Makefile
6–7	Redirects to HTTPS, it's so not in release directory...

Add a few suggestions

Harbormaster completed remote builds in B38630: Diff 87570.Apr 16 2021, 8:43 PM

In D29793#668445, @daniel.engberg.lists_pyret.net wrote:

Please switch to Meson if we're going to bump it.
You also need to verify the reason why we had to revert last time.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=249290

The thing with meson is that for cairo, we won't build the documentation if we use meson, and many options are still not enabled in meson yet. That's why autoreconf is being used.

I think they're in the process of switching to meson, and it's still incomplete.

This revision was not accepted when it landed; it landed in state Needs Review.May 24 2021, 7:17 PM

Closed by commit R11:dbca720cdec9: graphics/cario: Update to 1.17.4 (authored by nc). · Explain Why

This revision was automatically updated to reflect the committed changes.

nc added a commit: R11:dbca720cdec9: graphics/cario: Update to 1.17.4.