Page MenuHomeFreeBSD
Differential D29746

realtimer_expire: avoid proc lock recursion when called from itimer_proc_continue()
ClosedPublic
Actions

Authored by kib on Apr 13 2021, 1:52 PM.
Tags
None
Referenced Files
F103187170: D29746.diff
Fri, Nov 22, 1:09 AM
Unknown Object (File)
Wed, Nov 13, 10:32 PM
Unknown Object (File)
Wed, Nov 13, 10:27 PM
Unknown Object (File)
Mon, Nov 4, 10:46 AM
Unknown Object (File)
Sat, Nov 2, 7:49 AM
Unknown Object (File)
Oct 19 2024, 12:57 AM
Unknown Object (File)
Sep 29 2024, 3:15 PM
Unknown Object (File)
Sep 28 2024, 2:51 AM
View All 89 Files
Subscribers
None

Details

Reviewers
markj
Commits
rG75c5cf7a720f: filt_timerexpire: avoid process lock recursion
rG5cc1d199412e: realtimer_expire: avoid proc lock recursion when called from…
Summary

It is fine to drop the process lock there, process cannot exit until its timers are cleared.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Apr 13 2021, 1:52 PM
kib created this revision.
kib updated this revision to Diff 87378.Apr 13 2021, 1:54 PM

Upload the correct version of the patch.
PHOLD() there is not needed and is even wrong.

markj added a comment.Apr 13 2021, 2:04 PM

I believe there is a similar recursion with kqueue timers: kqtimer_proc_continue() holds the proc lock, and filt_timerexpire() may attempt to acquire it.

kib updated this revision to Diff 87379.Apr 13 2021, 2:27 PM

Handle recursion in filter_timerexpire()

markj accepted this revision.Apr 13 2021, 8:41 PM
This revision is now accepted and ready to land.Apr 13 2021, 8:41 PM
Closed by commit rG5cc1d199412e: realtimer_expire: avoid proc lock recursion when called from… (authored by kib). · Explain WhyApr 14 2021, 7:59 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG5cc1d199412e: realtimer_expire: avoid proc lock recursion when called from….
kib added a commit: rG75c5cf7a720f: filt_timerexpire: avoid process lock recursion.

Revision Contents
Changeset List

PathSize
sys/
kern/
24 lines

Diff 87423

View Options

sys/kern/kern_time.c

Loading...