security/gopass: update to 1.12.4
ClosedPublic
Actions

Authored by eduardo on Mar 21 2021, 6:16 AM.

Details

Reviewers

dbaio
garga

Commits

rP568940: security/gopass: Update to 1.12.4

Summary

security/gopass: Update to 1.12.4

Manpage is now installed by the `make install` command, there is no need to
install it in the `post-build` target anymore.

Changelog:  https://github.com/gopasspw/gopass/blob/v1.12.4/CHANGELOG.md

Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D29358

Test Plan

$ portlint -C
looks fine

poudriere testport:

114amd64 11.4-RELEASE-p8 amd64
122amd64 12.2-RELEASE-p4 amd64
140amd64 14.0-CURRENT amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

eduardo created this revision.Mar 21 2021, 6:16 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 21 2021, 6:16 AM

eduardo requested review of this revision.Mar 21 2021, 6:16 AM

eduardo edited the summary of this revision. (Show Details)

remove

cd ${GO_WRKSRC} && \
              ${SETENV} ${MAKE_ENV} ${GO_ENV} ${GO_CMD} run ${GO_BUILDFLAGS} ./helpers/man/main.go > ${PORTNAME}.1

since version 1.12.3:
[ENHANCEMENT] Install manpage when using make install (#1845)

eduardo added inline comments.Mar 21 2021, 6:30 AM

Makefile
78–79	[ENHANCEMENT] Install manpage when using make install (#1845)

I've updated your commit message, try to write why you made those changes (here in the ports tree).

Besides the update, you removed a command that install the manpage manually, which is noted in the changelog but will be clear this way.

This is my suggestion of course, there are people that like to write the full program changelog here in the commit message...

I prefer to separate the Port changelog from the Program changelog.

This revision is now accepted and ready to land.Mar 21 2021, 1:43 PM

Closed by commit rP568940: security/gopass: Update to 1.12.4 (authored by eduardo). · Explain WhyMar 22 2021, 6:49 AM

This revision was automatically updated to reflect the committed changes.

eduardo added a commit: rP568940: security/gopass: Update to 1.12.4.

In D29358#657462, @dbaio wrote:

This is my suggestion of course, there are people that like to write the full program changelog here in the commit message...

I prefer to separate the Port changelog from the Program changelog.

Ok, I will always use a separate changelog link in the future.