Differential D29021

growfs: allow operation on RW-mounted filesystems
ClosedPublic
Actions

Authored by emaste on Mar 2 2021, 10:43 PM.

Tags

None

Referenced Files

	F153452503: D29021.diff
	Tue, Apr 21, 6:23 AM

	Unknown Object (File)
	Mon, Apr 20, 3:08 AM

	Unknown Object (File)
	Sat, Apr 18, 8:21 AM

	Unknown Object (File)
	Wed, Apr 15, 8:30 AM

	Unknown Object (File)
	Sun, Apr 5, 2:39 AM

	Unknown Object (File)
	Fri, Apr 3, 8:34 PM

	Unknown Object (File)
	Wed, Apr 1, 3:22 AM

	Unknown Object (File)
	Wed, Mar 25, 5:49 AM

Subscribers

f0andrey_gmail.com

Details

Reviewers

Commits

rG8d25741b633a: growfs: allow operation on RW-mounted filesystems
rG56d80e35a333: growfs: allow operation on RW-mounted filesystems
rGb5920128c7eb: growfs: allow operation on RW-mounted filesystems
rG0dcde5cc1274: growfs: allow operation on RW-mounted filesystems

Summary

growfs supports growing mounted filesystems (writes are temporarily suspended while the grow happens). Drop the check for fs_clean == 0 to restore this case. Leave fs_flags check for FS_UNCLEAN or FS_NEEDSFSCK which represent the state of the filesystem when it was mounted, and fsck should be run first if they are set.

PR: 253754
Fixes: 6eb925f8450f ("Filesystem utilities that modify the...")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 2 2021, 10:43 PM

emaste created this revision.

emaste added inline comments.

sbin/growfs/growfs.c
1464	"Check for filesystem that was unclean at mount time." perhaps?

f0andrey_gmail.com added a subscriber: f0andrey_gmail.com.Mar 3 2021, 12:57 AM

Thanks, this fix live growfs

I agree that this change is appropriate.

This revision is now accepted and ready to land.Mar 3 2021, 9:02 PM

Closed by commit rG0dcde5cc1274: growfs: allow operation on RW-mounted filesystems (authored by emaste). · Explain WhyMar 3 2021, 11:37 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG0dcde5cc1274: growfs: allow operation on RW-mounted filesystems.

emaste added a commit: rGb5920128c7eb: growfs: allow operation on RW-mounted filesystems.Mar 6 2021, 1:13 AM

emaste added a commit: rG56d80e35a333: growfs: allow operation on RW-mounted filesystems.

emaste added a commit: rG8d25741b633a: growfs: allow operation on RW-mounted filesystems.Mar 6 2021, 7:47 PM

Revision Contents
Changeset List

Path

Size

sbin/

growfs/

5 lines

Diff 85094

sbin/growfs/growfs.c

Loading...