Page MenuHomeFreeBSD
Differential D3531

astro/stellarium: Drop USES=iconv.
ClosedPublic
Actions

Authored by rakuco on Aug 29 2015, 11:17 PM.
Tags
None
Referenced Files
F116878692: D3531.diff
Sun, May 11, 9:11 AM
Unknown Object (File)
Thu, May 8, 9:49 PM
Unknown Object (File)
Thu, Apr 24, 12:19 PM
Unknown Object (File)
Mon, Apr 14, 7:07 AM
Unknown Object (File)
Mon, Apr 14, 6:25 AM
Unknown Object (File)
Mon, Apr 14, 6:06 AM
Unknown Object (File)
Mon, Apr 14, 6:00 AM
Unknown Object (File)
Jan 24 2025, 5:06 AM
View All Files
Subscribers
None

Details

Reviewers
danfe
Commits
rP395607: Drop USES=iconv.
Summary

Even though the port still has a few FindIconv.cmake files scattered around, they are not actually used by the build system anymore, so the dependency is unnecessary.

Test Plan

Built fine on 10.1-amd64, the most problematic release in terms of iconv support.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 309
Build 309: arc lint + arc unit

Event Timeline

rakuco updated this revision to Diff 8342.Aug 29 2015, 11:17 PM
rakuco retitled this revision from to astro/stellarium: Drop USES=iconv..
rakuco updated this object.
rakuco edited the test plan for this revision. (Show Details)
rakuco added a reviewer: danfe.
danfe accepted this revision.Aug 30 2015, 7:25 AM
danfe edited edge metadata.

Fine by me, as long as it builds and iconv library indeed is not needed.

This revision is now accepted and ready to land.Aug 30 2015, 7:25 AM
Closed by commit rP395607: Drop USES=iconv. (authored by rakuco). · Explain WhyAug 30 2015, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
astro/
stellarium/
3 lines

Diff 8342

View Options

astro/stellarium/Makefile

Loading...