devel/libgit2-glib: Updated to 0.23.4
ClosedPublic
Actions

Authored by andoriyu_gmail.com on Aug 27 2015, 6:41 AM.

Details

Reviewers

wg
kwm

Group Reviewers

gnome
Contributor Reviewers (ports)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

andoriyu_gmail.com updated this revision to Diff 8246.Aug 27 2015, 6:41 AM

andoriyu_gmail.com retitled this revision from to devel/libgit2-glib: Updated to 0.23.4.

andoriyu_gmail.com updated this object.

andoriyu_gmail.com edited the test plan for this revision. (Show Details)

andoriyu_gmail.com added a reviewer: Contributor Reviewers (ports).

andoriyu_gmail.com added a parent revision: D3494: devel/libgit2: updated to 0.23.1.

andoriyu_gmail.com added a reviewer: gnome.Aug 27 2015, 4:45 PM

mmoll added a reviewer: wg.Aug 28 2015, 12:06 AM

at a first glance looks good to me but I would get review from someone else as well since I am not familiar with this port.

Like everything related to libgit2. This version is for libgit2 0.23 since it not API stable between 0.x releases.

The whole stack needs to be updated in one go. libgit2, libgit2-glib, gitg, py-pygit2 and rubygem-rugged. Like I did in https://svnweb.freebsd.org/changeset/ports/386103

This revision now requires changes to proceed.Aug 28 2015, 8:49 AM

Oh now I see the other ports. I think this would be more clear if there was 1 patch/review for all the ports instead of spreading them around in 1 review per patch. Since they depend quite closely with each other.

In D3499#71896, @kwm wrote:

Oh now I see the other ports. I think this would be more clear if there was 1 patch/review for all the ports instead of spreading them around in 1 review per patch. Since they depend quite closely with each other.

Do you want me to change it to one patch instead? I didn't know what the workflow for this situation and made one per port.