nc retitled this revision from New port: New port: misc/alive-progress: A new kind of Progress Bar to New port: misc/alive-progress: A new kind of Progress Bar.Jan 8 2021, 3:56 AM

nc edited the summary of this revision. (Show Details)

0mp requested changes to this revision.Jan 8 2021, 11:35 AM

0mp added inline comments.

misc/py-alive-progress/Makefile
6	Just a note: misc is probably not ideal, but from what I see there is a) no better place for this port b) most (if not all) other progress bar ports live in misc already, I guess we cannot do anything better here.
11	Comments should not start with "a/an". See the Porter's Handbook.
17	Please make sure that we do not need `concurrent` here.

This revision now requires changes to proceed.Jan 8 2021, 11:35 AM

Made a few updates requested my @0mp.

Harbormaster completed remote builds in B36031: Diff 81885.Jan 8 2021, 4:04 PM

nc retitled this revision from New port: misc/alive-progress: A new kind of Progress Bar to New port: misc/py-alive-progress: A new kind of Progress Bar.Jan 8 2021, 4:05 PM

nc edited the summary of this revision. (Show Details)

My comments seem to be addressed at this point. Approved.

This revision is now accepted and ready to land.Jan 8 2021, 4:24 PM

Closed by commit rP560791: New port: misc/py-alive-progress: A new kind of Progress Bar (authored by nc). · Explain WhyJan 8 2021, 4:29 PM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rP560791: New port: misc/py-alive-progress: A new kind of Progress Bar.