Page MenuHomeFreeBSD
Differential D28022

Fix the bug in committers-ports.dot with my mentor (0mp)
ClosedPublic
Actions

Authored by nc on Jan 7 2021, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 11:53 AM
Unknown Object (File)
Fri, Apr 11, 11:47 PM
Unknown Object (File)
Fri, Apr 11, 7:09 PM
Unknown Object (File)
Mar 8 2025, 2:19 PM
Unknown Object (File)
Mar 5 2025, 8:35 PM
Unknown Object (File)
Feb 10 2025, 11:39 AM
Unknown Object (File)
Feb 9 2025, 7:55 PM
Unknown Object (File)
Feb 5 2025, 12:21 AM
View All 65 Files
Subscribers
0mp
imp

Details

Reviewers
0mp
Commits
rG4d64c7243d26: Fix the bug in committers-ports.dot with my mentor.
Summary

Fix the bug in committers-ports.dot with my mentor (0mp)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35992
Build 32881: arc lint + arc unit

Event Timeline

nc created this revision.Jan 7 2021, 3:53 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 7 2021, 3:53 PM
nc requested review of this revision.Jan 7 2021, 3:53 PM
Harbormaster completed remote builds in B35992: Diff 81810.Jan 7 2021, 3:53 PM
0mp accepted this revision.Jan 7 2021, 4:01 PM

See if the file produces sensible outputs now (dot -T png -o file.png committers-ports.dot).

Otherwise, approved.

This revision is now accepted and ready to land.Jan 7 2021, 4:01 PM
Closed by commit rG4d64c7243d26: Fix the bug in committers-ports.dot with my mentor. (authored by nc). · Explain WhyJan 7 2021, 4:52 PM
This revision was automatically updated to reflect the committed changes.
nc added a commit: rG4d64c7243d26: Fix the bug in committers-ports.dot with my mentor..

Revision Contents
Changeset List

PathSize
share/
misc/
2 lines

Diff 81810

View Options

share/misc/committers-ports.dot

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Lines case LINUX_SYS_linux_clock_nanosleep:
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break; break;
case LINUX_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
emasteUnsubmitted
Not Done
Inline Actions

FWIW most (but not all) existing cases seem to follow the pattern

		c = ',';
		ip++;
		narg--;

(i.e., setting 'c' first)

emaste: FWIW most (but not all) existing cases seem to follow the pattern ``` c = ','; ip++; narg…
break;
case LINUX_SYS_linux_kill: case LINUX_SYS_linux_kill:
case LINUX_SYS_linux_tkill: case LINUX_SYS_linux_tkill:
case LINUX_SYS_linux_rt_sigqueueinfo: case LINUX_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
narg--; narg--;
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines case LINUX32_SYS_linux_clock_nanosleep:
sysdecode_linux_clockid(stdout, *ip); sysdecode_linux_clockid(stdout, *ip);
putchar(','); putchar(',');
ip++; ip++;
narg--; narg--;
print_mask_arg0(sysdecode_linux_clock_flags, *ip); print_mask_arg0(sysdecode_linux_clock_flags, *ip);
c = ','; c = ',';
ip++; ip++;
narg--; narg--;
break;
case LINUX32_SYS_linux_clone:
putchar('(');
print_mask_arg(sysdecode_linux_clone_flags, *ip);
ip++;
narg--;
c = ',';
break; break;
case LINUX32_SYS_linux_kill: case LINUX32_SYS_linux_kill:
case LINUX32_SYS_linux_tkill: case LINUX32_SYS_linux_tkill:
case LINUX32_SYS_linux_rt_sigqueueinfo: case LINUX32_SYS_linux_rt_sigqueueinfo:
print_number(ip, narg, c); print_number(ip, narg, c);
putchar(','); putchar(',');
print_linux_signal(*ip); print_linux_signal(*ip);
ip++; ip++;
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines