Page MenuHomeFreeBSD
Differential D3446

[NEW PORT] devel/p5-File-Copy-Link
ClosedPublic
Actions

Authored by loader on Aug 21 2015, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:22 PM
Unknown Object (File)
Fri, Dec 20, 3:57 PM
Unknown Object (File)
Fri, Dec 20, 3:43 PM
Unknown Object (File)
Fri, Dec 20, 10:49 AM
Unknown Object (File)
Thu, Dec 5, 5:07 PM
Unknown Object (File)
Thu, Dec 5, 12:59 AM
Unknown Object (File)
Wed, Dec 4, 11:19 AM
Unknown Object (File)
Nov 8 2024, 9:50 PM
View All Files
Subscribers
mat
sunpoet

Details

Reviewers
koobs
mat
Group Reviewers
Perl
Commits
rP396420: [NEW] devel/p5-File-Copy-Link: Extension for replacing
Summary

poudriere log: http://p.defau.lt/?lqUI12oCsx0VPoGxX8zzQA
% portlint -AC
looks fine.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 186
Build 186: arc lint + arc unit

Event Timeline

loader updated this revision to Diff 8101.Aug 21 2015, 3:55 PM
loader retitled this revision from to [NEW PORT] devel/p5-File-Copy-Link.
loader updated this object.
loader edited the test plan for this revision. (Show Details)
loader added a reviewer: koobs.
koobs added a reviewer: Perl.Aug 22 2015, 3:58 AM
koobs added inline comments.
devel/p5-File-Copy-Link/Makefile
12

Personally, I'd omit 'Perl5 module' from COMMENT

koobs accepted this revision.Aug 22 2015, 3:58 AM
koobs edited edge metadata.

Looks OK to me, pending Perl approval/response just to make sure.

This revision is now accepted and ready to land.Aug 22 2015, 3:58 AM
koobs added a comment.Aug 22 2015, 3:59 AM

@loader to clarify, you're free to commit this since I've accepted *unless* you want to wait for Perl.

koobs added inline comments.Aug 22 2015, 4:00 AM
devel/p5-File-Copy-Link/pkg-descr
6
  • https URL if possible/exists
  • Strip trailing slash unless URL redirect to with-slash
mat added a subscriber: mat.Aug 22 2015, 9:10 AM
mat added inline comments.
devel/p5-File-Copy-Link/pkg-descr
6
  1. cpan doesn't have https, 2) it redirects.
mat accepted this revision.Aug 22 2015, 9:11 AM
mat added a reviewer: mat.
sunpoet added a subscriber: sunpoet.Aug 22 2015, 9:43 AM
sunpoet added inline comments.
devel/p5-File-Copy-Link/Makefile
16

Please add NO_ARCH.

loader updated this revision to Diff 8125.Aug 22 2015, 12:11 PM
loader edited edge metadata.

add NO_ARCH= yes

This revision now requires review to proceed.Aug 22 2015, 12:11 PM
loader added a comment.Aug 22 2015, 12:13 PM

thanks @koobs, @mat, @sunpoet for your help.

loader updated this revision to Diff 8127.Aug 22 2015, 1:05 PM
loader edited edge metadata.

Update COMMENT and add NO_ARCH

koobs accepted this revision.Aug 23 2015, 4:25 AM
koobs edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 23 2015, 4:25 AM
mat added a comment.Sep 8 2015, 12:08 PM

Has this been forgotten ?

loader added a comment.Sep 8 2015, 3:46 PM

I'm waiting for the @Perl approval of updated patch ...

mat accepted this revision.Sep 8 2015, 4:21 PM
mat edited edge metadata.

Well, I'm Perl, please go ahead :-)

loader added a comment.Sep 8 2015, 5:53 PM

Thanks @mat

Closed by commit rP396420: [NEW] devel/p5-File-Copy-Link: Extension for replacing (authored by loader). · Explain WhySep 8 2015, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
1 line
20 lines
2 lines
5 lines
6 lines

Diff 8127

View Options

devel/Makefile

Loading...
View Options

devel/p5-File-Copy-Link/

Loading...
View Options

devel/p5-File-Copy-Link/Makefile

Loading...
View Options

devel/p5-File-Copy-Link/distinfo

Loading...
View Options

devel/p5-File-Copy-Link/pkg-descr

Loading...
View Options

devel/p5-File-Copy-Link/pkg-plist

Loading...