ukbd(4): Push LED events in ioctl handler rather than in xfer callback
ClosedPublic
Actions

Authored by wulf on Dec 23 2020, 9:30 PM.

Details

Reviewers

Commits

rGe8eded55f237: ukbd(4): Push LED events in ioctl handler rather than in xfer callback
rG30f34a519372: ukbd(4): Push LED events in ioctl handler rather than in xfer callback

Summary

If LED state is set through evdev interface, than asynchronous nature
of USB transfer callback can lead to change of order of events echoed
back to userland as it causes LED events to be echoed with some lag.

Fix that with echoing of LED events synchronously in ioctl handler.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf requested review of this revision.Dec 23 2020, 9:30 PM

wulf created this revision.

Don't forget to MFC all your changes!

This revision is now accepted and ready to land.Dec 24 2020, 11:35 AM

Closed by commit rG30f34a519372: ukbd(4): Push LED events in ioctl handler rather than in xfer callback (authored by wulf). · Explain WhyDec 24 2020, 7:13 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG30f34a519372: ukbd(4): Push LED events in ioctl handler rather than in xfer callback.

wulf added a commit: rGe8eded55f237: ukbd(4): Push LED events in ioctl handler rather than in xfer callback.Feb 5 2021, 10:20 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

input/

ukbd.c

10 lines

Diff 81142

View Options

ukbd(4): Push LED events in ioctl handler rather than in xfer callbackClosedPublicActions