Page MenuHomeFreeBSD
Differential D27578

Use uintptr_t instead of unsigned long for pointers.
ClosedPublic
Actions

Authored by jhb on Dec 11 2020, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 5:06 PM
Unknown Object (File)
Sat, Jan 11, 8:55 AM
Unknown Object (File)
Dec 25 2024, 10:43 PM
Unknown Object (File)
Dec 18 2024, 3:04 AM
Unknown Object (File)
Nov 25 2024, 5:00 PM
Unknown Object (File)
Nov 13 2024, 4:07 AM
Unknown Object (File)
Oct 26 2024, 7:25 PM
Unknown Object (File)
Oct 2 2024, 7:13 AM
View All 63 Files
Subscribers
imp

Details

Reviewers
imp
Commits
rS368686: Use uintptr_t instead of unsigned long for pointers.
Summary

The sense_ptr thing is quite broken. As near as I can tell,
the driver tries to copyout to a physical address rather than
whatever user address the sense buffer should be copied to.
It is not immediately obvious what user address the sense
buffer should be copied to.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Dec 11 2020, 9:25 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 11 2020, 9:25 PM
Harbormaster completed remote builds in B35358: Diff 80607.Dec 11 2020, 9:25 PM
jhb requested review of this revision.Dec 11 2020, 9:25 PM
imp accepted this revision.Dec 11 2020, 10:24 PM

no comment on what it's doing, but the casting I think is good.

This revision is now accepted and ready to land.Dec 11 2020, 10:24 PM
Closed by commit rS368686: Use uintptr_t instead of unsigned long for pointers. (authored by jhb). · Explain WhyDec 16 2020, 12:14 AM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rS368686: Use uintptr_t instead of unsigned long for pointers..

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
mrsas/
8 lines

Diff 80737

View Options

head/sys/dev/mrsas/mrsas_ioctl.c

Loading...