hyperv/vmbus: avoid crash, panic if vbe fb info is missing
ClosedPublic
Actions

Authored by bhughes on Dec 10 2020, 12:25 PM.

Details

Reviewers

Commits

rS368513: hyperv/vmbus: avoid crash, panic if vbe fb info is missing

Summary

Do not assume that VBE framebuffer metadata can be used. Like with the EFI fb metadata, it may be null, so we should take care not to dereference the null vbefb pointer. This avoids a panic when booting -CURRENT on a gen1 VM in Azure.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35294
Build 32227: arc lint + arc unit

Event Timeline

bhughes created this revision.Dec 10 2020, 12:25 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2020, 12:25 PM

bhughes requested review of this revision.Dec 10 2020, 12:25 PM

Harbormaster completed remote builds in B35294: Diff 80512.Dec 10 2020, 12:25 PM

bhughes retitled this revision from hyperv/vmbus: avoid crash, panic if vbe fb info is missing Do not assume that VBE framebuffer metadata can be used. Like with the EFI fb metadata, it may be null, so we should take care not to dereference the null vbefb pointer. This avoids a... to hyperv/vmbus: avoid crash, panic if vbe fb info is missing.Dec 10 2020, 12:26 PM

bhughes edited the summary of this revision. (Show Details)

Seems good, sorry about it:)

This revision is now accepted and ready to land.Dec 10 2020, 12:28 PM

Closed by commit rS368513: hyperv/vmbus: avoid crash, panic if vbe fb info is missing (authored by bhughes). · Explain WhyDec 10 2020, 1:12 PM

This revision was automatically updated to reflect the committed changes.

bhughes added a commit: rS368513: hyperv/vmbus: avoid crash, panic if vbe fb info is missing.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hyperv/

vmbus/

vmbus.c

32 lines

Diff 80512

View Options

sys/dev/hyperv/vmbus/vmbus.c

hyperv/vmbus: avoid crash, panic if vbe fb info is missingClosedPublicActions