qa.sh: Add eigen[23] and py-qt5 in proxydeps_suggest_uses
Needs ReviewPublic
Actions

Authored by lbartoletti on Nov 16 2020, 6:04 PM.

Details

Reviewers

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Summary

Hello,

kde@ would like to add eigen and py-qt5 in sugges_uses qa.sh

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34833
Build 31864: arc lint + arc unit

Event Timeline

lbartoletti created this revision.Nov 16 2020, 6:04 PM

Owners added a reviewer: O5: Ports Framework.Nov 16 2020, 6:04 PM

Herald added a reviewer: portmgr. · View Herald TranscriptNov 16 2020, 6:04 PM

Herald added a subscriber: mat. · View Herald Transcript

lbartoletti requested review of this revision.Nov 16 2020, 6:04 PM

Harbormaster completed remote builds in B34833: Diff 79618.Nov 16 2020, 6:04 PM

tcberner added inline comments.Nov 21 2020, 7:27 AM

Mk/Scripts/qa.sh
580	hm, eigen:* likely are not working as it only walks through the shared libraries getting linked against.

Try the following for eigen

Index: Mk/bsd.sanity.mk
===================================================================
--- Mk/bsd.sanity.mk    (revision 555776)
+++ Mk/bsd.sanity.mk    (working copy)
@@ -106,6 +106,12 @@
 DEV_ERROR+=    "All LIB_DEPENDS should use the new format and start out with lib.  \(libfoo.so vs foo.so\)"
 .endif

+.for _eigen_ver in 2 3
+.  if ((defined(BUILD_DEPENDS) && ${BUILD_DEPENDS:M*eigen${_eigen_ver}}) || (defined(RUN_DEPENDS) && ${RUN_DEPENDS:M*eigen${_eigen_ver}})) && (defined(USES) && empty(USES:Meigen*))
+DEV_WARNING+=  "Use USES=eigen:${_eigen_ver} to depend on math/eigen${_eigen_ver}"
+.  endif
+.endfor
+
 .if defined(LICENSE)
 .if ${LICENSE:MBSD}
 DEV_WARNING+=  "LICENSE must not contain BSD, instead use BSD[234]CLAUSE"

Revision Contents
Changeset List

Path

Size

Mk/

Scripts/

qa.sh

8 lines

Diff 79618

View Options

Mk/Scripts/qa.sh: Add eigen[23] and py-qt5 in proxydeps_suggest_usesNeeds ReviewPublicActions