Page MenuHomeFreeBSD

sysutils/datadog: new port PR208561
ClosedPublic

Authored by dch on Nov 11 2020, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 9:53 PM
Unknown Object (File)
Sun, Apr 21, 7:14 PM
Unknown Object (File)
Sat, Apr 20, 7:25 PM
Unknown Object (File)
Thu, Apr 4, 4:53 PM
Unknown Object (File)
Thu, Apr 4, 4:53 PM
Unknown Object (File)
Thu, Apr 4, 4:53 PM
Unknown Object (File)
Thu, Apr 4, 3:20 PM
Unknown Object (File)
Feb 18 2024, 8:21 AM
Subscribers

Details

Summary

Eponymous server and application monitoring and reporting agent from
DataDogHQ.com

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 34746
Build 31802: arc lint + arc unit

Event Timeline

dch requested review of this revision.Nov 11 2020, 7:38 PM
dch created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2020, 8:25 PM
This revision was automatically updated to reflect the committed changes.
mikael added inline comments.
head/sysutils/datadog/Makefile
3 ↗(On Diff #79442)

Why the port is named datadog and not datadog-agent?

15 ↗(On Diff #79442)

What kind of failures?

17–19 ↗(On Diff #79442)

not sorted

21 ↗(On Diff #79442)

Why don't you use go:modules?

28 ↗(On Diff #79442)

GH_ACCOUNT is not needed

30–31 ↗(On Diff #79442)

Why these 2 lines are needed?

35 ↗(On Diff #79442)

404

321 ↗(On Diff #79442)

Why do you delete go.mod?

351–359 ↗(On Diff #79442)

You can use GO_TARGET and put CGO_CFLAGS, CGO_LDFLAGS and GO_BUILDFLAGS in their own lines.
do-build is probably not needed

372–376 ↗(On Diff #79442)

You can use one MKDIR only.

383–385 ↗(On Diff #79442)

any reason to skip dogstatsd? for loop?

390 ↗(On Diff #79442)

make -C ${WRKSRC}/rtloader

398–399 ↗(On Diff #79442)

You can use a glob

head/sysutils/datadog/Makefile
23 ↗(On Diff #79442)

That seems really weird as a prefix: /usr/local/bin/datadog

23–25 ↗(On Diff #79442)

These variables should be defined later (after the USE_*)

310 ↗(On Diff #79442)

It should be defined with the other USE_x