Differential D26852

efibootmgr: Use returned error code for error message, not errno
ClosedPublic
Actions

Authored by freqlabs on Oct 19 2020, 5:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 29, 12:45 AM

	Unknown Object (File)
	Wed, May 27, 9:37 PM

	Unknown Object (File)
	Wed, May 27, 7:05 AM

	Unknown Object (File)
	Tue, May 26, 10:30 AM

	Unknown Object (File)
	Tue, May 26, 4:55 AM

	Unknown Object (File)
	Thu, May 21, 9:12 PM

	Unknown Object (File)
	Thu, May 21, 9:06 PM

	Unknown Object (File)
	May 20 2026, 12:43 AM

Subscribers

None

Details

Reviewers

Commits

rS367055: MFC r366830:
rS366830: efibootmgr: Use returned error code for error message, not errno

Summary

efivar_unix_path_to_device_path returns the error code, it does not set errno.

Test Plan

Before:

➜  ~ sudo efibootmgr -a -c -l /mnt/EFI/freebsd/loader.efi -L nvme0-FreeBSD
efibootmgr: Cannot translate unix loader path '\mnt\EFI\freebsd\loader.efi' to UEFI: No error: 0

After:

➜  ~ sudo efibootmgr -a -c -l /mnt/EFI/freebsd/loader.efi -L nvme0-FreeBSD
efibootmgr: Cannot translate unix loader path '\mnt\EFI\freebsd\loader.efi' to UEFI: No such file or directory

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs requested review of this revision.Oct 19 2020, 5:25 AM

freqlabs created this revision.

imp accepted this revision.Oct 19 2020, 10:25 AM

This revision is now accepted and ready to land.Oct 19 2020, 10:25 AM

Closed by commit rS366830: efibootmgr: Use returned error code for error message, not errno (authored by freqlabs). · Explain WhyOct 19 2020, 10:39 AM

This revision was automatically updated to reflect the committed changes.

freqlabs added a commit: rS366830: efibootmgr: Use returned error code for error message, not errno.

freqlabs added a commit: rS367055: MFC r366830:.Oct 26 2020, 12:35 PM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

efibootmgr/

13 lines

Diff 78418

head/usr.sbin/efibootmgr/efibootmgr.c

Loading...