Page MenuHomeFreeBSD
Differential D26386

Make several edits to the Apache webserver section in network servers including and update the SSL and PHP sections and make a note about the security reasons of using TLS.
ClosedPublic
Actions

Authored by trhodes on Sep 10 2020, 2:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 22 2024, 7:00 PM
Unknown Object (File)
Nov 22 2024, 2:00 PM
Unknown Object (File)
Nov 18 2024, 8:29 AM
Unknown Object (File)
Nov 15 2024, 11:19 AM
Unknown Object (File)
Nov 14 2024, 11:17 PM
Unknown Object (File)
Nov 14 2024, 8:01 AM
Unknown Object (File)
Nov 14 2024, 12:09 AM
Unknown Object (File)
Oct 3 2024, 1:53 PM
View All 52 Files
Subscribers
trhodes

Details

Reviewers
bcr
Summary

Update the mod_ssl and mod_php sections of the handbook.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33878
Build 31086: arc lint + arc unit

Event Timeline

trhodes requested review of this revision.Sep 10 2020, 2:13 AM
trhodes created this revision.
Harbormaster completed remote builds in B33479: Diff 76864.Sep 10 2020, 2:14 AM
bcr added a comment.Sep 10 2020, 6:42 AM

A fine addition to the chapter, well structured.
I've added a few comments and a suggestion inline.

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
3561

s/recommend/recommended/

3570

Superfluous "in"

3588

Is it "train of trust" or "chain of trust"?

There seems to be a word missing between "users" and "prevent".

3644–3647

You could have kept the <application>Apache</application> part here.

3672

How about simply "to activate it"?

trhodes updated this revision to Diff 77639.Sep 29 2020, 6:01 PM
trhodes marked 4 inline comments as done.

Update diff after speaking with bcr.

Updating D26386: Make several edits to the Apache webserver section in

network servers including and update the SSL and PHP
sections and make a note about the security reasons
of using TLS.

Harbormaster completed remote builds in B33878: Diff 77639.Sep 29 2020, 6:02 PM
bcr added a comment.Sep 30 2020, 8:07 AM

Minor thing remaining, the rest looks good.

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
3588

One more thing I noticed just now that I reread it: we discourage the use of "you".
See the "Be clear" section, fourth paragraph: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style.html

trhodes updated this revision to Diff 77805.Oct 3 2020, 5:26 AM
trhodes marked an inline comment as done.

I think this is the last one that covers all feedback.

Updating D26386: Make several edits to the Apache webserver section in

network servers including and update the SSL and PHP
sections and make a note about the security reasons
of using TLS.

Harbormaster completed remote builds in B33958: Diff 77805.Oct 3 2020, 5:26 AM
bcr accepted this revision.Oct 3 2020, 10:05 AM

Good to go now! Thanks.

This revision is now accepted and ready to land.Oct 3 2020, 10:05 AM
trhodes mentioned this in rD54573: Update the PHP and SSL subsections of the Apache section..Oct 4 2020, 5:08 AM
trhodes closed this revision.Nov 14 2021, 7:02 AM

I never closed this, very odd.

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml
3588

I'll change it to "for site visitors" or you think something else, such as end users is better?

3672

This is definitely less wordy, I'm trying to avoid ending a sentence with a preposition. :)

Maybe "to activate the new configuration" ? Or just leave it as is for now?

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
handbook/
network-servers/
174 lines

Diff 77639

View Options

en_US.ISO8859-1/books/handbook/network-servers/chapter.xml

Loading...