Page MenuHomeFreeBSD

bsd.port.mk: Handle incorrect binary aliases gracefully
ClosedPublic

Authored by 0mp on Sep 25 2020, 9:02 AM.
Tags
None
Referenced Files
F164254973: D26551.diff
Thu, Jul 30, 3:45 AM
Unknown Object (File)
Fri, Jul 24, 11:37 PM
Unknown Object (File)
Fri, Jul 24, 7:30 PM
Unknown Object (File)
Wed, Jul 22, 9:32 PM
Unknown Object (File)
Wed, Jul 22, 8:22 PM
Unknown Object (File)
Thu, Jul 9, 1:25 AM
Unknown Object (File)
Sat, Jul 4, 11:05 AM
Unknown Object (File)
Wed, Jul 1, 11:55 AM
Subscribers

Details

Reviewers
None
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP550426: bsd.port.mk: Handle incorrect binary aliases gracefully
Summary
bsd.port.mk: Handle incorrect binary aliases gracefully

Currently, if the src element of a BINARY_ALIAS pair is missing, the ports
framework would just print out the help message of install(1) and exit with a
failure. This might be hard to debug for novice ports users.

Let's introduce a check, which would allow us to print that the src component
is missing.

This situation happens more often than it seems to. For example, BINARY_ALIAS
tend to blow up when used for test dependencies, because binary aliases are
created before test dependencies are installed. This leads to a lot of
confusion for my experience.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33807
Build 31024: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Sep 25 2020, 9:02 AM

Assuming this was tested on all our supported releases.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2020, 1:47 PM
This revision was automatically updated to reflect the committed changes.