Page MenuHomeFreeBSD
Differential D3274

Update audio/idjc to 0.8.15
ClosedPublic
Actions

Authored by sbruno on Aug 2 2015, 3:20 PM.
Tags
None
Referenced Files
F172579015: D3274.id.diff
Sat, Sep 19, 10:16 AM
F172467922: D3274.diff
Fri, Sep 18, 4:35 PM
Unknown Object (File)
Fri, Sep 18, 7:56 AM
Unknown Object (File)
Wed, Sep 16, 1:40 PM
Unknown Object (File)
Thu, Sep 10, 11:28 PM
Unknown Object (File)
Wed, Sep 9, 1:31 PM
Unknown Object (File)
Tue, Sep 8, 10:12 PM
Unknown Object (File)
Mon, Sep 7, 8:28 PM
View All Files
Subscribers
kwm

Details

Reviewers
None
Commits
rP393437: Update to 0.8.15
Summary

Update audio/idjc to 0.8.15

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 7583.Aug 2 2015, 3:20 PM
sbruno retitled this revision from to Update audio/idjc to 0.8.15.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
kwm added a subscriber: kwm.Aug 2 2015, 3:26 PM
kwm added inline comments.
audio/idjc/pkg-plist
118

share/licenses/* files are added by the ports framework, no need to include them in the plist. If there still there something else is wrong.

119

%%NLS%% before the .mo files in the plist. Note that OPTIONS_SUB=yes needs to be set in the Makefile.

sbruno updated this revision to Diff 7584.Aug 2 2015, 3:32 PM

Remove licenses dir and add %%NLS%% as per review.

Add OPTIONS_SUB=yes

sbruno updated this revision to Diff 7585.Aug 2 2015, 4:24 PM

Declare NLS options, assign default options.

kwm added a comment.Aug 2 2015, 4:26 PM

Looks ok with the last suggestion.

audio/idjc/pkg-plist
75

Replace these lines with what the original plist had like:
%%PORTDOCS%%%%DOCSDIR%%/AUTHORS.gz

This way DOCS option will be honored

sbruno updated this revision to Diff 7587.Aug 2 2015, 4:37 PM

Move files around to make the diff smaller

sbruno updated this revision to Diff 7588.Aug 2 2015, 5:05 PM
sbruno marked 2 inline comments as done.

Final pass and cleanup after review

sbruno marked an inline comment as done.Aug 2 2015, 5:05 PM
Closed by commit rP393437: Update to 0.8.15 (authored by sbruno). · Explain WhyAug 2 2015, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
audio/
idjc/
11 lines
4 lines
101 lines

Diff 7585

View Options

audio/idjc/Makefile

Loading...
View Options

audio/idjc/distinfo

Loading...
View Options

audio/idjc/pkg-plist

Loading...