Don't forget to check the vendor when probing. Also, there's no need to double check for if the card has probed before. In fact, there's no reason to single check either. Simplify the code as a result.
ClosedPublic
Actions

Authored by imp on Jul 31 2015, 10:02 PM.

Details

Reviewers

scottl
benno

Commits

rS286208: Don't forget to check the vendor when probing. Also, there's no need

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

imp updated this revision to Diff 7557.Jul 31 2015, 10:02 PM

imp retitled this revision from to Don't forget to check the vendor when probing. Also, there's no need to double check for if the card has probed before. In fact, there's no reason to single check either. Simplify the code as a result..

imp updated this object.

imp edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2015, 10:02 PM

imp added a reviewer: scottl.Aug 1 2015, 3:24 AM

benno accepted this revision.Aug 2 2015, 3:33 AM

benno added a reviewer: benno.

This revision is now accepted and ready to land.Aug 2 2015, 3:33 AM

Closed by commit rS286208: Don't forget to check the vendor when probing. Also, there's no need (authored by imp). · Explain WhyAug 2 2015, 4:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

pms/

freebsd/

driver/

common/

lxutil.c

47 lines

ini/

src/

agtiapi.c

46 lines

Diff 7557

View Options

sys/dev/pms/freebsd/driver/common/lxutil.c